Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor source code (partial) #23

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

derobins
Copy link
Collaborator

Cleans up and encapsulates about 1/3 of the original fabtsuite code.

derobins and others added 30 commits September 17, 2022 09:53
The move to the types header is temporary. Most of the types will
be moved to new sub-files as we refactor the code. There's currently
many circular dependencies there, so it's easiest to create a central
type file and fix up the typedefs later.
Also added -f to the symlink command so it's quiet when reinstalling
@derobins derobins requested a review from carns August 22, 2023 20:11
@carns
Copy link
Contributor

carns commented Aug 28, 2023

Thanks @derobins . I'm trying to get the origin/main build up and running on Polaris again (so that I can then test the PR) but I'm confused by cmake :)

After customizing a few things I've got a clean build and I try to run it using cmake test. I get this:

[carns@polaris-login-01 build (main)]$ make test
Running tests...
Test project /home/carns/working/src/mochi/fabtsuite/build
    Start 1: single-node
1/7 Test #1: single-node ......................***Failed    2.03 sec
    Start 2: FI_WAIT_FD
2/7 Test #2: FI_WAIT_FD .......................***Failed    0.29 sec
    Start 3: fi_cancel
3/7 Test #3: fi_cancel ........................***Failed    0.29 sec
    Start 4: cross-job-comm
4/7 Test #4: cross-job-comm ...................***Failed    0.30 sec
    Start 5: multi-thread
5/7 Test #5: multi-thread .....................***Failed    0.29 sec
    Start 6: vectored-IO
6/7 Test #6: vectored-IO ......................***Failed    0.36 sec
    Start 7: MPI-interoperability
7/7 Test #7: MPI-interoperability .............***Failed    0.29 sec

0% tests passed, 7 tests failed out of 7

Total Test time (real) =   3.88 sec

The following tests FAILED:
	  1 - single-node (Failed)
	  2 - FI_WAIT_FD (Failed)
	  3 - fi_cancel (Failed)
	  4 - cross-job-comm (Failed)
	  5 - multi-thread (Failed)
	  6 - vectored-IO (Failed)
	  7 - MPI-interoperability (Failed)
Errors while running CTest

Can you tell me how to find the output from the tests so that I can see what's wrong? I believe this is probably a generic cmake question, not really about the code.

Alternatively maybe just tell me how to submit the qsub script by hand? I tried just running qsub fabtrun.qsub but that doesn't seem quite right, even after adjusting the file a bit to account for the paths and filesystem attributes required on Polaris now. If I can figure that out then I will document it; I'm not wild about running job scripts from a make check command for development purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants