-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor source code (partial) #23
base: main
Are you sure you want to change the base?
Conversation
The move to the types header is temporary. Most of the types will be moved to new sub-files as we refactor the code. There's currently many circular dependencies there, so it's easiest to create a central type file and fix up the typedefs later.
Also added -f to the symlink command so it's quiet when reinstalling
Thanks @derobins . I'm trying to get the origin/main build up and running on Polaris again (so that I can then test the PR) but I'm confused by cmake :) After customizing a few things I've got a clean build and I try to run it using
Can you tell me how to find the output from the tests so that I can see what's wrong? I believe this is probably a generic cmake question, not really about the code. Alternatively maybe just tell me how to submit the qsub script by hand? I tried just running |
Cleans up and encapsulates about 1/3 of the original fabtsuite code.