chore: change name logger to fit with the name of the library #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uriii3
reviewed
Jul 22, 2024
Comment on lines
+16
to
17
| blank_logger = logging.getLogger("copernicusmarine_blank_logger") | ||
|
|
There was a problem hiding this comment.
what is this blank logger for?
There was a problem hiding this comment.
It's basically to distiguish between normal logging and when you return true "outputs" of the program!
We use it in the describe and in the get when you do --show-outputnames
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Renamed the logger to `copernicusmarine` to fit with the convention that the logger is usually with the same name as the library
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Renamed the logger to `copernicusmarine` to fit with the convention that the logger is usually with the same name as the library
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
Renamed the logger to `copernicusmarine` to fit with the convention that the logger is usually with the same name as the library
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
Renamed the logger to `copernicusmarine` to fit with the convention that the logger is usually with the same name as the library
renaudjester
added a commit
that referenced
this pull request
Aug 29, 2024
Renamed the logger to `copernicusmarine` to fit with the convention that the logger is usually with the same name as the library
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Renamed the logger to `copernicusmarine` to fit with the convention that the logger is usually with the same name as the library
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Renamed the logger to `copernicusmarine` to fit with the convention that the logger is usually with the same name as the library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://cms-change.atlassian.net/browse/CMT-55