Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: centralising the documentation #155

Merged
merged 14 commits into from
Oct 18, 2024
Merged

Conversation

uriii3
Copy link
Collaborator

@uriii3 uriii3 commented Oct 4, 2024

We wanted to have all the descriptions (helps) of the variables the same way and easy to change: to do so, we centralise the documentation of the variables in a single code.

@uriii3 uriii3 changed the base branch from main to copernicusmarine-toolbox-v2 October 4, 2024 10:00
@uriii3 uriii3 requested a review from renaudjester October 7, 2024 10:56
@uriii3 uriii3 force-pushed the documenting branch 3 times, most recently from db7e99e to fe1022a Compare October 14, 2024 14:15
@uriii3
Copy link
Collaborator Author

uriii3 commented Oct 14, 2024

With the rework, I will take care of the definitions of the variables are kept the same. The only missing thing, for the moment, is the description of the functions and the response description too. Don't know if it is worth, too, to implement a check on those.

I will review the documentation with the word once again to check that all the changes are kept the same and properly.

@uriii3 uriii3 requested a review from renaudjester October 14, 2024 15:45
conda_environment_test.yaml Outdated Show resolved Hide resolved
copernicusmarine/command_line_interface/group_get.py Outdated Show resolved Hide resolved
copernicusmarine/command_line_interface/group_get.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils 2.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils 2.py Outdated Show resolved Hide resolved
copernicusmarine/python_interface/open_dataset.py Outdated Show resolved Hide resolved
copernicusmarine/python_interface/login.py Show resolved Hide resolved
doc/command-line-interface.rst Show resolved Hide resolved
tests/test_documentation.py Outdated Show resolved Hide resolved
tests/test_documentation.py Show resolved Hide resolved
check back

some updates

finalising the dictionary

should work for the subset

all python api interface documentation updated

Trying to see if this will work

check back

some updates

finalising the dictionary

should work for the subset

all python api interface documentation updated

all cli documentation update

all cli documentation update

order of decorators

add description and response

parts, version updates

delete example

ready to rebase

coords selection method docs

last changes mainly and will correct tests and main revision

some updates on the docstrings

documentation updated

Some tests on the matter

add numpydoc

updating snapshots

description changes

Error in the describe

delete one file

first batch of changes

check with r

changes after comments on pr
copernicusmarine/command_line_interface/group_get.py Outdated Show resolved Hide resolved
copernicusmarine/command_line_interface/group_get.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils.py Outdated Show resolved Hide resolved
copernicusmarine/core_functions/documentation_utils.py Outdated Show resolved Hide resolved
copernicusmarine/download_functions/utils.py Show resolved Hide resolved
tests/test_documentation.py Show resolved Hide resolved
Comment on lines 67 to 68
request_file : Union[pathlib.Path, str], optional
Path to a file containing request parameters. For more information, please refer to the README.
Option to pass a file containing the arguments. For more information please refer to the documentation or use option ``--create-template`` for an example template.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heey, here I used the same description as in the subset but the option create template definitely doesn't exist for the get. Do you have any idea on how we could rewrite this option to be able to explain the request_file without the create template?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-18 at 09 28 13

It definitely exists

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in the API though, no?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! I guess you could just say: documentation or use option ``--create-template`` from the command line interface for an example template

@uriii3
Copy link
Collaborator Author

uriii3 commented Oct 17, 2024

Only remaining:

  • Update snapshots
  • Rewrite request file for python API
  • Get your good to go on the description of the login -> it was okey like before.

Basically my last two comments and update snapshots before merging!

@uriii3 uriii3 merged commit 61dbe0a into copernicusmarine-toolbox-v2 Oct 18, 2024
2 checks passed
@uriii3 uriii3 deleted the documenting branch October 18, 2024 12:15
renaudjester pushed a commit that referenced this pull request Oct 28, 2024
Co-authored-by: Renaud <[email protected]>
Refactoring to try to centralise as much as possible the documentation. Rewording some definitions and adding some documentation were necessary.
renaudjester pushed a commit that referenced this pull request Oct 28, 2024
Co-authored-by: Renaud <[email protected]>
Refactoring to try to centralise as much as possible the documentation. Rewording some definitions and adding some documentation were necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants