Use s3 product dataset mapping #151
Conversation
renaudjester
changed the base branch from
main
to
copernicusmarine-toolbox-v2
| Common and Custom errors | ||
| ========================== | ||
|
|
||
| Custom errors | ||
| ------------- |
There was a problem hiding this comment.
I started doing this so I'll finish it here but the most important of this pull requests is the fact that we are using the mapping from the s3 metadata instead of a local file
| - The dataset id is incorrect and not present in the catalog. | ||
| - The dataset has been retired. | ||
|
|
||
| Please verifiy that the dataset id is can be found in |
There was a problem hiding this comment.
some typo I understand, no? without the 'is' makes more sense
| """ | ||
| Exception raised when other options are passed with create_template. | ||
|
|
||
| Please note that create_template should be passed with no other optiond |
|
|
||
|
|
||
| class CredentialCannotBeNone(Exception): | ||
| """ | ||
| Exception raised when a credential are not set. |
There was a problem hiding this comment.
plural or singular? credentials are not set or credential is not set (no?)
|
|
||
| .. _pypi: https://pypi.org/project/copernicusmarine/ | ||
| .. _conda-forge: https://anaconda.org/conda-forge/copernicusmarine | ||
| .. _dockerhub: https://hub.docker.com/r/copernicusmarine/copernicusmarine | ||
| .. _copernicusmarine-register: https://data.marine.copernicus.eu/register | ||
| .. _Anaconda: https://www.anaconda.com/products/individual |
There was a problem hiding this comment.
what is all of this? I understand the correction is because I messed it up, but what does it do?
There was a problem hiding this comment.
Just a way to put all the links at the same place but it's just some synthax from restructuredText
| MARINE_DATA_STORE_ROOT_METADATA_URL = ( | ||
| "https://s3.waw3-1.cloudferro.com/mdl-metadata" | ||
| ) |
There was a problem hiding this comment.
this is the new link no? to update it, the action is somewhere else I understand, right?
| product_id = connection.get_json_file(dataset_product_mapping_url).get( | ||
| dataset_id |
There was a problem hiding this comment.
I understand that this has been check that it works, right? do yo feel it is more or less the time we anticipated?
Use the s3 product dataset mapping and add errors in the doc and in the copernicus package
Use the s3 product dataset mapping and add errors in the doc and in the copernicus package
Finishing the task on stop using cache
Also started to document the custom errors of the toolbox