Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean the readme to the minimum and put the information in the… #145

Merged

Conversation

renaudjester
Copy link
Collaborator

Fix CMT-26
Fix CMT-25
Fix CMT-17 🥳

@renaudjester renaudjester requested a review from uriii3 September 23, 2024 12:09

.. note:: Requires Python 3.9 or higher.

Via conMamba | Condada (conda-forge channel)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conMamba? Condada? Not this, no?

Comment on lines +87 to +96

- ``--bounding-box-method inside``:
- Returns longitudes within the range: [0.08334, 0.917]

- ``--bounding-box-method nearest``:
- Returns longitudes: [0.0, 2.917]

- ``--bounding-box-method outside``:
- Outputs longitudes from: [0.0, 3.0]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really weird! I don't know if there is any way maybe to mark all the parts that are not readable and then correct them later? This one will be outdated in no-time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you correct it then

About ``--netcdf3-compatible`` option
""""""""""""""""""""""""""""""""""""""""

The ``--netcdf3-compatible`` option enables compatibility with the netCDF3 format. This uses the ``format="NETCDF3_CLASSIC"`` setting in the xarray `to_netcdf` method. [Documentation link](https://docs.xarray.dev/en/latest/generated/xarray.Dataset.to_netcdf.html).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is not properly seen, I don't know what is happening!

Comment on lines +10 to +14
> copernicusmarine login
username : johndoe
password :
INFO - Configuration files stored in /Users/foo/.copernicusmarine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is outdated, my problem!


If the ``.copernicusmarine-credentials`` file already exists, the system will ask for confirmation before overwriting it (using the ``--overwrite`` or ``--overwrite-configuration-file`` options).

You can also use the ``--skip-if-user-logged-in`` option to prevent overwriting the configuration file if the user is already logged in.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this about? it shouldn't ask suer to login if they have the credentials, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea :D

Comment on lines +19 to +24
Access Points Migration and Evolution
-------------------------------------

If you still have configurations for legacy services (for example, files like ``~/motuclient/motuclient-python.ini``, ``~/.netrc``, or ``~/_netrc`` in your home directory), these will automatically be recognized by the ``get`` and ``subset`` commands without needing to run the ``login`` command.

If your configuration files are stored in a different directory, you can point to them by using the ``--credentials-file`` option when running the ``get`` or ``subset`` commands.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also recommend to update to the newer version of the copernicusmarine registration and that's it? So that we know that users will migrate slowly, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not about changing the registration it's about where you put your credentials!

Copy link
Collaborator

@uriii3 uriii3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only be seen when it is fully released, right? I think it will definitely need a check but can be done after everything is implemented.

@uriii3
Copy link
Collaborator

uriii3 commented Sep 23, 2024

Also, about the contribution guide, maybe we will also need to specify a bit more how we want people to interact with it, no? Just saying that we welcome contributions might be too open to interpretation.
Anyway, another think also to maybe discuss in the future, let's see how it goes like this.

@renaudjester renaudjester merged commit 8f29948 into copernicusmarine-toolbox-v2 Sep 23, 2024
2 checks passed
@renaudjester renaudjester deleted the clean-readme-and-pour-in-doc branch September 23, 2024 16:14
renaudjester added a commit that referenced this pull request Oct 28, 2024
renaudjester added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants