new-feature: create binaries with GitHub Actions #142
Conversation
| python -m pip install --upgrade pip | ||
| pip install pyinstaller | ||
| pip install -e . | ||
| pip install poetry |
There was a problem hiding this comment.
you can take this part and put it into a make command
There was a problem hiding this comment.
I still think that it would be better to do all of this into a mamba env
There was a problem hiding this comment.
Also with the mamba env it seems like you have access to a power-shell for windows
There was a problem hiding this comment.
It is already into a makefile, no? I don't understand what you mean.
Yes, but I was a bit scared because I don't fully understand the mamba things so I'm not so sure that it would work better... seems to work fine like this!
There was a problem hiding this comment.
Yeah I know the mamba thing can be some work but it would be nice because it keeps environment installation the same across the repo
In the repo, for github action we never use pure pip commands
uriii3
force-pushed
the
creating_executable
branch
from
3e9562f to
5ab9900
Compare
uriii3
force-pushed
the
creating_executable
branch
from
bb37a68 to
79ab6db
Compare
Co-authored-by: Renaud <[email protected]>
Co-authored-by: Renaud <[email protected]>
Co-authored-by: Renaud <[email protected]>
Co-authored-by: Renaud <[email protected]> Co-authored-by: renaudjester <[email protected]>
Co-authored-by: Renaud <[email protected]> Co-authored-by: renaudjester <[email protected]>
Add GitHub Actions so that the binaries are created at every release or pre-release.
--add-dataoption works