chore: proposal to update the terminal output for the login #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_command_line_interface.py
Outdated
| b"Downloading CMEMS data requires a Copernicus Marine username " | ||
| b"and password, sign up for free at:" | ||
| b" https://data.marine.copernicus.eu/register" | ||
| ) in self.output.stderr | ||
| assert b"username:" in self.output.stdout |
There was a problem hiding this comment.
check that "copernicusmarine username:" is in the stdout
and maybe the password too 🤔
There was a problem hiding this comment.
I'm not sure we are entering anything, so not that sure that "coperniscusmarine password" appears there.... but I'll try. Do you prefer that I enter something to check if not?
There was a problem hiding this comment.
Ah yeah true :D You can try by putting an input in the execute_command
There was a problem hiding this comment.
check the tests and where they failed, it is this! We don't check that the password exists.
renaudjester
approved these changes
Sep 19, 2024
|
Fixes #139 (added this to make sure the PR is linked to the issue, but it does not seem to work) |
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Making it easier for users to understand the login functionality.
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Making it easier for users to understand the login functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to followup on Issue-139. Seems like a good idea to point out where the registration is from within the toolbox.
Not sure if the option of having it in the ReadMe is enough, to be discussed.