fix: decimal not handled with modulus #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uriii3
reviewed
Sep 17, 2024
| # Modulus with python return a negative value if the denominator is negative | ||
| # To counteract that, we add 360 if the result is < 0 | ||
| modulus = modulus if modulus >= 0 else modulus + 360 | ||
| return modulus - 180 | ||
| return float(modulus - 180) |
There was a problem hiding this comment.
do we still need the float here?
There was a problem hiding this comment.
Yes :D To keep the types consistent
uriii3
approved these changes
Sep 17, 2024
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Fix a bug where the decimals for the longitude wouldn't be considered properly for the check of bounds
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Fix a bug where the decimals for the longitude wouldn't be considered properly for the check of bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug with full test datasets where the decimals were not correctly handled
this would fail: