test: cf checker #127
Merged
test: cf checker #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudjester
approved these changes
Sep 9, 2024
|
Seems like the json output isn't consistent in all the runs (sometimes max appears first and sometimes second). I've asked the library to check this, maybe it can be of help. Meanwhile, I've started the correction, so that if we don't have the warnings we don't need them to be ordered. |
Not using any cache anymore Always get the data on the fly
renaudjester
approved these changes
Sep 17, 2024
Comment on lines
+437
to
+438
| [dataset[variable].attrs["valid_min"]], | ||
| dtype=dataset[variable].encoding["dtype"], |
There was a problem hiding this comment.
Nice! maybe you should talk with Guille anyway about this if the valid minmax that comes from arco is different then the variable normal value
There was a problem hiding this comment.
well, all of them have the same format (if int, int, if float, float) but the precision might be different... I'll ask anyway, yes!
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Co-authored-by: Renaud <[email protected]> Add a compliance checker to make sure that the netcdf output files are as expected.
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Co-authored-by: Renaud <[email protected]> Add a compliance checker to make sure that the netcdf output files are as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will add a compliant checker for netcdf files to be run within the GitHub actions to check that all the files are properly created. Related to CMT-7