Use only timezones for datetime parser #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uriii3
reviewed
Aug 7, 2024
Comment on lines
125
to
148
| def datetime_parser(string: str) -> datetime: | ||
| if string == "now": | ||
| return datetime.now() | ||
| for format in DATETIME_SUPPORTED_FORMATS: | ||
| try: | ||
| return datetime.strptime(string, format) | ||
| except ValueError: | ||
| pass | ||
| return datetime.now(tz=timezone.utc).replace(tzinfo=None) | ||
| try: | ||
| return ( | ||
| datetime.fromisoformat(string) | ||
| .astimezone(timezone.utc) | ||
| .replace(tzinfo=None) | ||
| ) | ||
| except ValueError: | ||
| for format in DATETIME_SUPPORTED_FORMATS: | ||
| try: | ||
| return datetime.strptime(string, format) | ||
| except ValueError: | ||
| pass |
There was a problem hiding this comment.
so this basically ensures that all strings are setted with a timezone to UTC. But do we know if all the 'dates' are being held first as strings?
Should we check that all dates are set with a certain timezone?
There was a problem hiding this comment.
# now
>>> datetime_parser("now")
datetime.datetime(2024, 8, 8, 7, 58, 37, 248673)
# with timezone in the name
>>> datetime_parser("2024-06-18T13:00:00.000+02:00")
datetime.datetime(2024, 6, 18, 11, 0)
# full date in the timezone of the computer
>>> datetime_parser("2024-06-18T13:00:00.000")
datetime.datetime(2024, 6, 18, 11, 0)
# full date UTC
>>> datetime_parser("2024-06-18T13:00:00.000Z")
datetime.datetime(2024, 6, 18, 13, 0)
# year month day WRONG
>>> datetime_parser("2024-06-18")
datetime.datetime(2024, 6, 17, 22, 0)
So yeah I will look a bit more into it
|
Then, for any date that is being played with, should be passed within this function, no? Should we review the code or it0s already done and we keep in mind for the following implementations? |
uriii3
approved these changes
Aug 19, 2024
renaudjester
force-pushed
the
use-only-timezones-for-datetime-parser
branch
from
bf04505 to
3d27ae3
Compare
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
take into account the timezone when parsing datetime and getting the time from the computer
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
take into account the timezone when parsing datetime and getting the time from the computer
renaudjester
added a commit
that referenced
this pull request
Aug 29, 2024
take into account the timezone when parsing datetime and getting the time from the computer
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
take into account the timezone when parsing datetime and getting the time from the computer
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
take into account the timezone when parsing datetime and getting the time from the computer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CMT-64