chore: deleting valid_min and valid_max attributes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uriii3
force-pushed
the
copernicusmarine-toolbox-v2
branch
2 times, most recently
from
55f580d to
dccee67
Compare
uriii3
force-pushed
the
deleting_validminmax
branch
from
04dad1b to
b4515df
Compare
uriii3
force-pushed
the
deleting_validminmax
branch
from
e6cdd55 to
58608bf
Compare
renaudjester
approved these changes
Aug 5, 2024
renaudjester
pushed a commit
that referenced
this pull request
Aug 20, 2024
Deleting the valid_min and valid_max attributes from the dimensions, as requested to comply with CF conventions.
renaudjester
pushed a commit
that referenced
this pull request
Aug 20, 2024
Deleting the valid_min and valid_max attributes from the dimensions, as requested to comply with CF conventions.
renaudjester
pushed a commit
that referenced
this pull request
Aug 29, 2024
Deleting the valid_min and valid_max attributes from the dimensions, as requested to comply with CF conventions.
uriii3
changed the title
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Deleting the valid_min and valid_max attributes from the dimensions, as requested to comply with CF conventions.
renaudjester
pushed a commit
that referenced
this pull request
Oct 28, 2024
Deleting the valid_min and valid_max attributes from the dimensions, as requested to comply with CF conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in CMT-53, I deleted the valid_min and valid_max attributes for the dimensions.
Still needs to be determined if we want to add min or max values as suggested, but it looks like we don't retrieve such values from the metadata...