re-record tortoise metrics when phase or mode is changed (#231)

controllers/tortoise_controller.go

@@ -109,14 +109,19 @@ func (r *TortoiseReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_
 		return ctrl.Result{RequeueAfter: r.Interval}, nil
 	}
 
-	metrics.RecordTortoise(tortoise, false)
+	oldTortoise := tortoise.DeepCopy()
 
 	defer func() {
 		if tortoise == nil {
 			logger.Error(reterr, "get error during the reconciliation, but cannot record the event because tortoise object is nil", "tortoise", req.NamespacedName)
 			return
 		}
 
+		if metrics.ShouldRerecordTortoise(oldTortoise, tortoise) {
+			metrics.RecordTortoise(oldTortoise, true)
+			metrics.RecordTortoise(tortoise, false)
+		}
+
 		tortoise = r.TortoiseService.RecordReconciliationFailure(tortoise, reterr, now)
 		_, err = r.TortoiseService.UpdateTortoiseStatus(ctx, tortoise, now, false)
 		if err != nil {

pkg/metrics/metrics.go

@@ -3,8 +3,6 @@ package metrics
 import (
 	"github.com/prometheus/client_golang/prometheus"
 	"sigs.k8s.io/controller-runtime/pkg/metrics"
-
-	"github.com/mercari/tortoise/api/v1beta3"
 )
 
 var (
@@ -80,18 +78,3 @@ func init() {
 		TortoiseNumber,
 	)
 }
-
-func RecordTortoise(t *v1beta3.Tortoise, deleted bool) {
-	value := 1.0
-	if deleted {
-		value = 0
-	}
-	TortoiseNumber.WithLabelValues(
-		t.Name,
-		t.Namespace,
-		t.Spec.TargetRefs.ScaleTargetRef.Name,
-		t.Spec.TargetRefs.ScaleTargetRef.Kind,
-		string(t.Spec.UpdateMode),
-		string(t.Status.TortoisePhase),
-	).Set(value)
-}

pkg/metrics/tortoisenumber.go

@@ -0,0 +1,25 @@
+package metrics
+
+import (
+	"github.com/mercari/tortoise/api/v1beta3"
+)
+
+func RecordTortoise(t *v1beta3.Tortoise, deleted bool) {
+	value := 1.0
+	if deleted {
+		value = 0
+	}
+	TortoiseNumber.WithLabelValues(
+		t.Name,
+		t.Namespace,
+		t.Spec.TargetRefs.ScaleTargetRef.Name,
+		t.Spec.TargetRefs.ScaleTargetRef.Kind,
+		string(t.Spec.UpdateMode),
+		string(t.Status.TortoisePhase),
+	).Set(value)
+}
+
+func ShouldRerecordTortoise(old, new *v1beta3.Tortoise) bool {
+	return old.Status.TortoisePhase != new.Status.TortoisePhase ||
+		old.Spec.UpdateMode != new.Spec.UpdateMode
+}