Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update TransactionDetailsRequest #322

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

danielen-meli
Copy link
Contributor

📝 Description

  • As pointed out by @miguelvelasquezdev, there was a need to include TransactionDetailsRequest to create payment via PSE;
  • This PR include TransactionDetailsRequest in Create Payment;

✅ Checklist:

  • I followed the instructions indicated in Contribution Guidelines
  • I added the changes to CHANGELOG
  • Added the necessary tests for the code or functionality that I'm working on
  • I ran the tests and made sure they work
  • My branch coverage is at least 80%
  • I verified the style of my code matches the one in the project

🧰 How to reproduce

  • Not Apply.
  • Step by step of how to test, specially for bugs.
  • Links of external docs.

📸 Screenshots

  • Not Apply.
  • Before and after, if it's a fix for a bug.

📄 References

  • Not Apply.
  • Links do external documentation.
  • Diagrams.
  • Useful links.

@miguelvelasquezdev
Copy link

thaaanks

@danielen-meli danielen-meli merged commit 4e22128 into master Apr 29, 2024
4 checks passed
@eltinMeli eltinMeli deleted the feature/update-transaction-details branch August 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants