Merge/foundation release/1.10.9 fix remotefreezer #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date: 2021-10-13 11:14:53-07:00 Signed-off-by: meows <[email protected]>
Interfaces are do-ers. This interfaces defines an operator, not an operation. Date: 2021-10-14 05:58:35-07:00 Signed-off-by: meows <[email protected]>
…Freezer Date: 2021-10-14 06:51:40-07:00 Signed-off-by: meows <[email protected]>
…for test freezer store mock Date: 2021-10-14 08:30:09-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-14 08:44:27-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-14 09:23:33-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-14 09:23:55-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-14 09:24:11-07:00 Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
…mem) Append method Date: 2021-10-15 07:43:33-07:00 Signed-off-by: meows <[email protected]>
…teConcise passes Date: 2021-10-15 08:18:14-07:00 Signed-off-by: meows <[email protected]>
…s Error Date: 2021-10-18 09:24:46-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-18 09:29:05-07:00 Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Date: 2021-10-21 09:11:03-07:00 Signed-off-by: meows <[email protected]>
…ssignment at CommitGenesis This fixes most tests. I'm not sure yet exactly why. One remaining failing test: TestIncompleteAncientReceiptChainInsertion_RemoteFreezer Date: 2021-10-21 09:14:10-07:00 Signed-off-by: meows <[email protected]>
InsertReceiptChain calls the db accessor directly, and the terminateInsert function got ill-formed for the job. We're going to limit our responsibility for the remote freezer (client) implementations; other tests show that the server side of the API is functioning correctly. Date: 2021-10-21 09:54:12-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-21 10:39:36-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-21 10:51:17-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-21 10:56:20-07:00 Signed-off-by: meows <[email protected]>
meowsbits
commented
Oct 21, 2021
| Config: params.TestChainConfig, | ||
| Alloc: genesisT.GenesisAlloc{address: {Balance: funds}}, | ||
| BaseFee: big.NewInt(vars.InitialBaseFee), | ||
| Difficulty: vars.MinimumDifficulty, |
meowsbits
commented
Oct 21, 2021
| @@ -95,7 +95,7 @@ type AncientWriter interface { | |||
| // ModifyAncients runs a write operation on the ancient store. | |||
| // If the function returns an error, any changes to the underlying store are reverted. | |||
| // The integer return value is the total size of the written data. | |||
| ModifyAncients(func(AncientWriteOp) error) (int64, error) | |||
| ModifyAncients(func(AncientWriteOperator) error) (int64, error) | |||
There was a problem hiding this comment.
This is just a rename. Interface names should be do-ers. This disambiguates between "operation" and "operator."
meowsbits
commented
Oct 21, 2021
cmd/ancient-store-mem/lib/mem.go
Outdated
| @@ -117,6 +120,36 @@ func (f *MemFreezerRemoteServerAPI) AppendAncient(number uint64, hash, header, b | |||
| return nil | |||
| } | |||
|
|
|||
| func (f *MemFreezerRemoteServerAPI) Append(kind string, num uint64, item interface{}) error { | |||
| // if num < f.count || num > f.count+1 { | |||
There was a problem hiding this comment.
errOutOfOrder requirements are unfinished.
There was a problem hiding this comment.
This was fixed with 2a9289e and the one after it.
Date: 2021-10-21 11:03:37-07:00 Signed-off-by: meows <[email protected]>
meowsbits
commented
Oct 21, 2021
|
|
||
| return b.api.AppendAncient(num) | ||
| err = b.client.Call(&res, FreezerMethodWriteAppend, kind, num, common.Bytes2Hex(bs)) |
There was a problem hiding this comment.
RLP-encoded bytes are further encoded in hex for transmission. The client needs to decode first from hex, then from RLP.
In core/genesis.go a default value for difficulty is provided in GenesisToBlock, the vars.GenesisDifficulty value. This value was not used in CommitGenesis, where instead genesis.Difficulty (instead of block.Difficulty()) was used. As you can see in the diff, the vars.GenesisDifficulty.Int64() value is added to the preexisting expected TD outcomes for Short and Long reorg tests. Date: 2021-10-21 13:00:04-07:00 Signed-off-by: meows <[email protected]>
…ed errOutOfOrder conditions Date: 2021-10-26 08:43:53-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-26 10:31:24-07:00 Signed-off-by: meows <[email protected]>
Date: 2021-10-27 08:48:50-07:00 Signed-off-by: meows <[email protected]>
meowsbits
force-pushed
the
merge/foundation-release/1.10.9
branch
from
9dd8280 to
04a7829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.