Skip to content

Commit

Permalink
Added more cypress tests, updated constants (opensearch-project#282)
Browse files Browse the repository at this point in the history 
* added more tests, updated constants

Signed-off-by: Shenoy Pratik <[email protected]>

* removed timeout for on clone

Signed-off-by: Shenoy Pratik <[email protected]>
  • Loading branch information
@ps48
ps48 authored Dec 2, 2021
1 parent ba52143 commit 849be7c
Show file tree
Hide file tree
Showing 3 changed files with 131 additions and 12 deletions.
121 changes: 113 additions & 8 deletions .cypress/integration/panels.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ import {
TEST_PANEL,
PPL_VISUALIZATIONS,
PPL_VISUALIZATIONS_NAMES,
NEW_VISUALIZATION_NAME,
PPL_FILTER,
SAMPLE_PANEL,
SAMPLE_VISUALIZATIONS_NAMES,
} from '../utils/panel_constants';

const moveToEventsHome = () => {
Expand Down Expand Up @@ -79,13 +82,10 @@ describe('Creating visualizations', () => {

describe('Testing panels table', () => {
beforeEach(() => {
cy.visit(
`${Cypress.env('opensearchDashboards')}/app/observability-dashboards#/operational_panels/`
);
cy.wait(delay * 3);
moveToPanelHome();
});

it('Displays error toast for invalid notebook name', () => {
it('Displays error toast for invalid panel name', () => {
cy.get('.euiButton__text').contains('Create new panel').click();
cy.wait(delay);
cy.get('.euiButton__text')
Expand Down Expand Up @@ -179,7 +179,39 @@ describe('Testing a panel', () => {
moveToTestPanel();
});

it('Duplicate the open panel', () => {
cy.get('.euiButton__text').contains('Panel actions').click();
cy.wait(delay);
cy.get('.euiContextMenuItem__text').contains('Duplicate panel').click();
cy.wait(delay);
cy.get(`input.euiFieldText[value="${TEST_PANEL} (copy)"]`).should('exist');
cy.get('.euiButton__text').contains('Duplicate').click();
cy.wait(delay * 3);
cy.get('.euiToastHeader__title').contains('successfully').should('exist');
cy.get('h1')
.contains(TEST_PANEL + ' (copy)')
.should('exist');
cy.wait(delay);
});

it('Rename the open panel', () => {
cy.get('.euiButton__text').contains('Panel actions').click();
cy.wait(delay);
cy.get('.euiContextMenuItem__text').contains('Rename panel').click();
cy.wait(delay);
cy.get(`input.euiFieldText[value="${TEST_PANEL} (copy)"]`)
.focus()
.clear()
.type('Renamed Panel');
cy.get('.euiButton__text').contains('Rename').click();
cy.wait(delay * 3);
cy.get('.euiToastHeader__title').contains('successfully').should('exist');
cy.get('h1').contains('Renamed Panel').should('exist');
cy.wait(delay);
});

it('Change date filter of the panel', () => {
moveToTestPanel();
cy.get('.euiButtonEmpty[data-test-subj="superDatePickerToggleQuickMenuButton"]').click();
cy.get('.euiLink').contains('This year').click();
cy.wait(delay * 2);
Expand Down Expand Up @@ -249,6 +281,21 @@ describe('Testing a panel', () => {
cy.wait(delay);
});

it('Resize a visualization', () => {
cy.get('.euiButton__text').contains('Edit').click();
cy.wait(delay);
cy.get('.react-resizable-handle')
.eq(1)
.trigger('mousedown', { which: 1 })
.trigger('mousemove', { clientX: 1600, clientY: 500 })
.trigger('mouseup', { force: true });
cy.wait(delay);
cy.get('.euiButton__text').contains('Save').click();
cy.wait(delay * 3);
cy.get('div.react-grid-layout>div').eq(1).invoke('height').should('match', new RegExp('310'));
cy.wait(delay);
});

it('Delete a visualization', () => {
cy.get('h5').contains(PPL_VISUALIZATIONS_NAMES[1]).should('exist');
cy.get('.euiButton__text').contains('Edit').click();
Expand Down Expand Up @@ -289,12 +336,30 @@ describe('Testing a panel', () => {
cy.wait(delay);
});

it('Move to explorer to create new visualization', () => {
it('Create new visualization and add to panel', () => {
cy.get('.euiButton__text').contains('Add Visualization').click();
cy.wait(delay);
cy.get('.euiContextMenuItem__text').contains('Create New Visualization').click();
cy.wait(delay * 3);
cy.url().should('match', new RegExp('(.*)#/event_analytics/explorer'));

cy.get('[id^=autocomplete-textarea]').type(PPL_VISUALIZATIONS[2]);
cy.get('.euiButton__text').contains('Refresh').click();
cy.wait(delay);
cy.get('.tab-title').contains('Visualizations').click();
cy.wait(delay);
cy.get('.euiButton__text').contains('Save').click();
cy.wait(delay);
cy.get('.euiComboBox__input').type(TEST_PANEL);
cy.get(`input[value="${TEST_PANEL}"]`).click();
cy.get('.euiFieldText').type(PPL_VISUALIZATIONS_NAMES[2]);
cy.get('.euiPopoverFooter>.euiFlexGroup>:nth-child(2)').contains('Save').click();
cy.wait(delay);
cy.get('.euiToastHeader__title').contains('successfully').should('exist');
moveToTestPanel();
cy.get('h5').contains(PPL_VISUALIZATIONS_NAMES[0]).should('exist');
cy.get('h5').contains(PPL_VISUALIZATIONS_NAMES[1]).should('exist');
cy.get('h5').contains(PPL_VISUALIZATIONS_NAMES[2]).should('exist');
});

it('Move to test panel and check visualization edit button', () => {
Expand All @@ -305,12 +370,52 @@ describe('Testing a panel', () => {
cy.wait(delay * 3);
cy.url().should('match', new RegExp('(.*)#/event_analytics/explorer'));
cy.wait(delay);
cy.get('.euiButton__text').contains('Save').click();
cy.wait(delay);
cy.get('.euiFieldText').focus().clear().type(NEW_VISUALIZATION_NAME);
cy.get('.euiPopoverFooter>.euiFlexGroup>:nth-child(2)').contains('Save').click();
cy.wait(delay);
cy.get('.euiToastHeader__title').contains('successfully').should('exist');
moveToTestPanel();
cy.get('h5').contains(NEW_VISUALIZATION_NAME).should('exist');
cy.get('h5').contains(PPL_VISUALIZATIONS_NAMES[1]).should('exist');
cy.get('h5').contains(PPL_VISUALIZATIONS_NAMES[2]).should('exist');
});
});

describe('Clean up all test data', () => {
describe('Add samples and clean up all test data', () => {
it('Add sample data', () => {
moveToPanelHome();
cy.get('.euiButton__text').contains('Actions').click();
cy.wait(delay);
cy.get('.euiContextMenuItem__text').contains('Add samples').click();
cy.wait(delay);
cy.get('.euiModalHeader__title[data-test-subj="confirmModalTitleText"]')
.contains('Add samples')
.should('exist');
cy.wait(delay);
cy.get('.euiButton__text').contains('Yes').click();
cy.wait(delay * 5);
cy.get('.euiTableCellContent').contains(SAMPLE_PANEL).should('exist');
cy.wait(delay);
});

it('Validate sample data', () => {
moveToPanelHome();
cy.get('.euiTableCellContent').contains(SAMPLE_PANEL).click();
cy.wait(delay * 3);
cy.get('h1').contains(SAMPLE_PANEL).should('exist');
cy.wait(delay);
SAMPLE_VISUALIZATIONS_NAMES.forEach((vizName) =>
cy.get('h5').contains(vizName).should('exist')
);
cy.wait(delay);
});

it('Delete visualizations from event analytics', () => {
moveToEventsHome();
cy.get('.euiButtonEmpty__text').contains('Rows per page: 10').click();
cy.get('.euiContextMenuItem__text').contains('50 rows').click();
cy.get('.euiCheckbox__input[data-test-subj="checkboxSelectAll"]').click();
cy.wait(delay);
cy.get('.euiButton__text').contains('Actions').click();
Expand All @@ -323,7 +428,7 @@ describe('Clean up all test data', () => {
cy.get('input.euiFieldText[placeholder="delete"]').type('delete');
cy.get('button.euiButton--danger').should('not.be.disabled');
cy.get('.euiButton__text').contains('Delete').click();

cy.wait(delay);
cy.get('.euiTextAlign').contains('No Queries or Visualizations').should('exist');
});

Expand Down
18 changes: 17 additions & 1 deletion .cypress/utils/panel_constants.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,34 @@
* SPDX-License-Identifier: Apache-2.0
*/

export const delay = 1500;
export const delay = 700;

export const TEST_PANEL = 'Test Panel';
export const SAMPLE_PANEL = '[Logs] Web traffic Panel';

export const SAMPLE_VISUALIZATIONS_NAMES = [
'[Logs] Average ram usage by operating systems',
'[Logs] Average ram usage per day by apple os',
'[Logs] Average ram usage per day by windows os',
'[Logs] Daily count for error response codes',
'[Logs] Count requests from US to CN, IN and JP',
'[Logs] Max and average bytes by host',
'[Logs] Count total requests by tags',
'[Logs] Daily average bytes',
];

export const PPL_VISUALIZATIONS = [
'source = opensearch_dashboards_sample_data_flights | stats count() by Dest',
'source = opensearch_dashboards_sample_data_flights | stats avg(FlightDelayMin) by Carrier',
'source = opensearch_dashboards_sample_data_flights | stats max( DistanceKilometers ) by DestCityName',
];

export const PPL_VISUALIZATIONS_NAMES = [
'Flight count by destination',
'Average flight delay minutes',
'Max distance by destination city',
];

export const NEW_VISUALIZATION_NAME = 'Flight count by destination airport';

export const PPL_FILTER = "where Carrier = 'OpenSearch-Air' | where Dest = 'Munich Airport'";
4 changes: 1 addition & 3 deletions public/components/custom_panels/custom_panel_view.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,7 @@ export const CustomPanelView = ({

const onClone = async (newCustomPanelName: string) => {
cloneCustomPanel(newCustomPanelName, panelId).then((id: string) => {
setTimeout(() => {
window.location.assign(`${_.last(parentBreadcrumb).href}${id}`);
}, 1000);
window.location.assign(`${_.last(parentBreadcrumb).href}${id}`);
});
closeModal();
};
Expand Down

0 comments on commit 849be7c

Please sign in to comment.