Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin API should listen on all interfaces #705

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

xiwenc
Copy link
Contributor

@xiwenc xiwenc commented Dec 11, 2023

Admin interface can be exposed safely on all interfaces in a container model because it requires a password to access privileged functions. This is needed for the /Prometheus endpoint to work. Because pod scraping by Prometheus is initiated outside of the pod.

…r model because it requires password to access privileged functions
@jeohist jeohist changed the base branch from master to develop December 29, 2023 18:08
@jeohist jeohist merged commit 48dea8f into mendix:develop Jun 11, 2024
27 checks passed
@jeohist
Copy link
Contributor

jeohist commented Jun 11, 2024

Thanks for your contribution @xiwenc ! It will be included in our next release.

mukund-padale added a commit that referenced this pull request Aug 22, 2024
* Bump certifi from 2024.2.2 to 2024.6.2 (#754)

Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.6.2.
- [Commits](certifi/python-certifi@2024.02.02...2024.06.02)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ruff from 0.4.5 to 0.4.8 (#756)

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.4.5 to 0.4.8.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.4.5...v0.4.8)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump requests from 2.32.2 to 2.32.3 (#753)

Bumps [requests](https://github.com/psf/requests) from 2.32.2 to 2.32.3.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.2...v2.32.3)

---
updated-dependencies:
- dependency-name: requests
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pytest from 8.2.1 to 8.2.2 (#763)

Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@8.2.1...8.2.2)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pylint from 3.2.2 to 3.2.3 (#764)

* Bump cryptography from 42.0.7 to 42.0.8 (#762)

* admin API should listen on all interfaces (#705)

* MET-2698 - Changing the startup order for user-metering sidecar (#784)

* MET-2698 - Changing the startup order for user-metering sidecar

* MET-2698 - Increased timeout due to failures in the pipeline

* Disable New Relic / Splunk tests

* Fix fluentbit config, set explicit host IP

* Enable Splunk and Newrelic tests

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xiwen Cheng <[email protected]>
Co-authored-by: Joey den Broeder <[email protected]>
Co-authored-by: rus-kh <[email protected]>
Co-authored-by: ekremsekerci <[email protected]>
Co-authored-by: Denis Shuvalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants