send dependencies.json in client-config request #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekamte-mx
previously requested changes
Jun 15, 2023
AlbertDeVries2
force-pushed
the
DB-2086_send_dependencies_json_in_client_config_call
branch
from
fea22c9
to
3e5690a
Compare
sailhenz
approved these changes
Jun 28, 2023
sailhenz
deleted the
DB-2086_send_dependencies_json_in_client_config_call
branch
AlbertDeVries2
restored the
DB-2086_send_dependencies_json_in_client_config_call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the client-config request to the cf-kafka-broker is updated to a PUT instead of a GET that excepts the dependencies.json file in the body. The start is modified to read this file and send it in the request.
note: shouldn't be merged before the cf-kafka-broker changes are live