Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest gorilla/websocket library #921

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Update to latest gorilla/websocket library #921

merged 1 commit into from
Jan 11, 2022

Conversation

lluiscampos
Copy link
Contributor

@lluiscampos lluiscampos requested review from tranchitella and a user January 10, 2022 13:40
@mender-test-bot
Copy link

@lluiscampos, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline".

my commands and options
You can trigger a pipeline on multiple prs with:
  • mentioning me and start pipeline --pr mender/127 --pr mender-connect/255

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@lluiscampos
Update to latest gorilla/websocket library
7ffd5ec 
Now that upstream have merged our PR. Slightly modify our code
accordingly.

See:
* gorilla/websocket#745
* gorilla/websocket#746

Changelog: None

Signed-off-by: Lluis Campos <[email protected]>
@lluiscampos
Copy link
Contributor Author

@mender-test-bot start pipeline 🧦

@mender-test-bot
Copy link

Hello 😸 I created a pipeline for you here: Pipeline-444784530

Build Configuration Matrix

Key Value
AUDITLOGS_REV master
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
CREATE_ARTIFACT_WORKER_REV master
DEPLOYMENTS_ENTERPRISE_REV master
DEPLOYMENTS_REV master
DEVICEAUTH_ENTERPRISE_REV master
DEVICEAUTH_REV master
DEVICECONFIG_REV master
DEVICECONNECT_REV master
DEVICEMONITOR_REV master
GUI_REV master
INTEGRATION_REV master
INVENTORY_ENTERPRISE_REV master
INVENTORY_REV master
IOT_MANAGER_REV master
MENDER_ARTIFACT_REV master
MENDER_CLI_REV master
MENDER_CONNECT_REV master
MENDER_REV pull/921/head
MONITOR_CLIENT_REV master
MTLS_AMBASSADOR_REV master
REPORTING_REV master
RUN_INTEGRATION_TESTS true
TENANTADM_REV master
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
USERADM_ENTERPRISE_REV master
USERADM_REV master
WORKFLOWS_ENTERPRISE_REV master
WORKFLOWS_REV master

tranchitella
tranchitella approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@tranchitella tranchitella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

ghost
ghost approved these changes Jan 11, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@lluiscampos lluiscampos merged commit 6b3ed4b into mendersoftware:master Jan 11, 2022
@lluiscampos lluiscampos deleted the update-websockets-upstream branch January 11, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tranchitella tranchitella tranchitella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lluiscampos @mender-test-bot @tranchitella