Merge pull request #83 from memgraph/release/0.4.2

Chore: Add release 0.4.2

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.4.2
+
+### Fix
+
+* Fix: resizeObserver is not unobserved (#82) (fixes #81) - by @markusnissl
+
 ## 0.4.1
 
 ### Fix

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@memgraph/orb",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "Graph visualization library",
   "engines": {
     "node": ">=16.0.0"

src/views/default-view.ts

@@ -39,6 +39,7 @@ export type IDefaultViewSettingsInit<N extends INodeBase, E extends IEdgeBase> =
 
 export class DefaultView<N extends INodeBase, E extends IEdgeBase> implements IOrbView<IDefaultViewSettings<N, E>> {
   private _container: HTMLElement;
+  private _resizeObs: ResizeObserver;
   private _graph: IGraph<N, E>;
   private _events: OrbEmitter<N, E>;
   private _strategy: IEventStrategy<N, E>;
@@ -96,8 +97,8 @@ export class DefaultView<N extends INodeBase, E extends IEdgeBase> implements IO
     this._settings.render = this._renderer.getSettings();
 
     // Resize the canvas based on the dimensions of its parent container <div>.
-    const resizeObs = new ResizeObserver(() => this._handleResize());
-    resizeObs.observe(this._container);
+    this._resizeObs = new ResizeObserver(() => this._handleResize());
+    this._resizeObs.observe(this._container);
     this._handleResize();
 
     this._d3Zoom = zoom<HTMLCanvasElement, any>()
@@ -215,6 +216,7 @@ export class DefaultView<N extends INodeBase, E extends IEdgeBase> implements IO
   }
 
   destroy() {
+    this._resizeObs.unobserve(this._container);
     this._renderer.removeAllListeners();
     this._simulator.terminate();
     this._canvas.outerHTML = '';

src/views/map-view.ts

@@ -59,6 +59,7 @@ export type IMapViewSettingsUpdate<N extends INodeBase, E extends IEdgeBase> = P
 
 export class MapView<N extends INodeBase, E extends IEdgeBase> implements IOrbView<IMapViewSettings<N, E>> {
   private _container: HTMLElement;
+  private _resizeObs: ResizeObserver;
   private _graph: IGraph<N, E>;
   private _events: OrbEmitter<N, E>;
   private _strategy: IEventStrategy<N, E>;
@@ -106,8 +107,8 @@ export class MapView<N extends INodeBase, E extends IEdgeBase> implements IOrbVi
     this._settings.render = this._renderer.getSettings();
 
     // Resize the canvas based on the dimensions of it's parent container <div>.
-    const resizeObs = new ResizeObserver(() => this._handleResize());
-    resizeObs.observe(this._container);
+    this._resizeObs = new ResizeObserver(() => this._handleResize());
+    this._resizeObs.observe(this._container);
     this._handleResize();
 
     this._leaflet = this._initLeaflet();
@@ -166,6 +167,7 @@ export class MapView<N extends INodeBase, E extends IEdgeBase> implements IOrbVi
   }
 
   destroy() {
+    this._resizeObs.unobserve(this._container);
     this._renderer.removeAllListeners();
     this._leaflet.off();
     this._leaflet.remove();