Use active socket #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
requested changes
Apr 26, 2024
| raise "TCP Socket receiving error, reason: #{inspect(reason)}" | ||
| end | ||
| def handle_demand(_pad, size, _unit, _ctx, state) do | ||
| :inet.setopts(state.local_socket.socket_handle, active: size) |
There was a problem hiding this comment.
This makes sense if only if the demand unit is buffers, you can enforce it in def_output_pad
lib/membrane_tcp/source.ex
Outdated
| } | ||
|
|
||
| { | ||
| [buffer: {:output, %Buffer{payload: payload, metadata: metadata}}, redemand: :output], |
There was a problem hiding this comment.
since we request the same amount of buffers from TCP that is demanded, the redemand is not needed
mat-hek
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the Source so that it relies on a
:gen_tcpsocket using active mode rather than non-active, since the latter seems to use a lot more CPU in our implmentation, especially where the demand is higher than supply. To keep the flow control features the socket is using theactive: :onceoractive: N, which limits the amount of messages that the element will receive before returning toactive: falsestate.