Add repeat_last_request functions #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
allow-repeating-requests
branch
from
7ef3f2e to
fd4f01e
Compare
mat-hek
requested changes
Aug 22, 2024
Comment on lines
+22
to
+29
| if is_port(socket), do: :inet.setopts(socket, active: false) | ||
|
|
||
| result = | ||
| with :ok <- mockable(:gen_tcp).send(socket, request) do | ||
| recv(socket, response_timeout) | ||
| end | ||
|
|
||
| if is_port(socket), do: :inet.setopts(socket, active: true) |
There was a problem hiding this comment.
let's create a dumb socket in tests and remove is_port checks here
| def teardown(session, headers \\ []), do: request(session, "TEARDOWN", headers) | ||
|
|
||
| @spec repeat_last_request(t()) :: Response.result() | ||
| def repeat_last_request(session), do: GenServer.call(session, :repeat_last_request) |
There was a problem hiding this comment.
So instead, as we spoke, let's send the response from the TCP decapsulator back to the RTSP session and remove *_no_response functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:tcp_closedmessage and terminate immediately