Improve rtsp decapsulator #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Noarkhh
commented
Apr 15, 2024
•
Noarkhh
commented
- Start forwarding RTCP packets
- Start forwarding packets from all interleaved channels, since they will be differentiated with ssrc
- Handle cases where an interleaved RTSP message is split between multiple buffers or is succeded by a RTP packet in a buffer, where previously these packets would be dropped
…ple buffers or is succeded by a RTP packet in a buffer
Noarkhh
force-pushed
the
improve-rtsp-decapsulator
branch
from
be30ba2 to
a0b4ac4
Compare
mat-hek
requested changes
May 8, 2024
README.md
Outdated
| @@ -15,7 +15,7 @@ The package can be installed by adding `membrane_rtp_plugin` to your list of dep | |||
| ```elixir | |||
| def deps do | |||
| [ | |||
| {:membrane_rtp_plugin, "~> 0.27.1"}, | |||
| {:membrane_rtp_plugin, "~> 0.28.0"}, | |||
There was a problem hiding this comment.
I would bump the version and release after we move the decapsulator to the rtsp plugin
There was a problem hiding this comment.
Ok, I wasn't planning on releasing, but the bump can be done when actually moving the element.
| rest_length = actual_length - expected_length | ||
| rtsp_message_length = byte_size(rtsp_message_start) - rest_length | ||
|
|
||
| <<rtsp_message::binary-size(rtsp_message_length)-unit(8), rest::binary>> = |
There was a problem hiding this comment.
Suggested change
| <<rtsp_message::binary-size(rtsp_message_length)-unit(8), rest::binary>> = | |
| <<rtsp_message::binary-size(rtsp_message_length), rest::binary>> = |
mat-hek
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.