Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bundlex dependency to 1.4, fix for cross-compile on OSX. #51

Closed
wants to merge 1 commit into from

Conversation

CJRChang
Copy link

Updated to use Bundlex.platform() to better support cross-compilation while on OSX.

@darthez darthez requested a review from Noarkhh January 17, 2024 14:48
@darthez darthez requested a review from mat-hek February 8, 2024 15:13
@Noarkhh
Copy link
Contributor

Noarkhh commented Mar 18, 2024

Hi!

I apologize for the wait. We've been busy addressing the issue you made us aware of in Bundlex: membraneframework/bundlex#124.

We concluded that having two public functions (Bundlex.get_target/0 and Bundlex.platform/0) was unnecessary and confusing. We chose to keep Bundlex.get_target/0 because it can detect cross-compilation and convey more information, such as the target's OS and architecture. These details are also conveniently provided when cross-compiling using Nerves.

We decided to deprecate Bundlex.platform/0, as Bundlex.get_target/0 can effectively replace it.

Thank you for your contribution! Even though I will be closing this PR, it prompted us to fix the underlying issue in Bundlex. Once Bundlex is upgraded to 1.5 here, cross-compilation will be fully supported :)

@Noarkhh Noarkhh closed this Mar 18, 2024
@Noarkhh
Copy link
Contributor

Noarkhh commented Mar 18, 2024

I just updated the plugin to use Bundlex ~> 1.5, so this should now work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants