Create Ogg.Muxer #12
Create Ogg.Muxer #12
Conversation
* Simplify demuxer by having one static output pad * Raise if input Ogg stream has multiple streams
Noarkhh
force-pushed
the
create-muxer
branch
2 times, most recently
from
828924e to
f630876
Compare
lib/muxer.ex
Outdated
| alias Membrane.Ogg.Page | ||
|
|
||
| def_input_pad :input, | ||
| flow_control: :auto, |
There was a problem hiding this comment.
| flow_control: :auto, |
lib/muxer.ex
Outdated
| accepted_format: %Membrane.Opus{self_delimiting?: false} | ||
|
|
||
| def_output_pad :output, | ||
| flow_control: :auto, |
There was a problem hiding this comment.
| flow_control: :auto, |
lib/muxer.ex
Outdated
| end | ||
|
|
||
| @impl true | ||
| def handle_buffer(:input, %Buffer{pts: pts} = buffer, _ctx, state) when not is_nil(pts) do |
There was a problem hiding this comment.
let's check for the duration in metadata as well
lib/opus.ex
Outdated
| @spec create_plc_packets(Membrane.Time.t(), Membrane.Time.t()) :: [plc_packet()] | ||
| def create_plc_packets(gap_start_timestamp, gap_duration) do | ||
| # PLC = Packet Loss Concealment | ||
| if rem(gap_duration, @shortest_frame_duration) != 0, do: raise("Unrecoverable gap") |
There was a problem hiding this comment.
I guess we shouldn't expect PTS to be perfectly precise. I'd add some tolerance factor here and maybe just warn in that case. Please try using this in a WebRTC -> OGG pipeline. You can use this example as a reference: https://github.com/membraneframework/membrane_webrtc_plugin/blob/master/examples/browser_to_file.exs
There was a problem hiding this comment.
When running this example the timestamps are precise, but I'll add some error margin just in case
lib/muxer.ex
Outdated
| encapsulate_packets( | ||
| rest_packets, | ||
| %{state | total_duration: state.total_duration + first_packet.metadata.duration}, | ||
| actions ++ new_actions |
There was a problem hiding this comment.
since it seems we only accumulate buffers here, let's make it buffers instead of actions and send them all in a single action
README.md
Outdated
There was a problem hiding this comment.
let's mention that the examples are in the examples folder
There was a problem hiding this comment.
It was already mentioned, but I noticed the example was really outdated, so I updated it
closes membraneframework/membrane_core#802