Put known pts in metadata #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
reviewed
May 13, 2024
mix.exs
Outdated
Comment on lines
43
to
51
| {:membrane_file_plugin, "~> 0.16.0", only: :test, runtime: false}, | ||
| {:membrane_portaudio_plugin, "~> 0.18.0", only: :test, runtime: false}, | ||
| {:membrane_opus_plugin, "~> 0.19.0", only: :test, runtime: false}, | ||
| # {:membrane_opus_plugin, "~> 0.20.2", only: :test, runtime: false}, | ||
| {:membrane_opus_plugin, | ||
| github: "membraneframework/membrane_opus_plugin", | ||
| branch: "use-ogg-time-metadata", | ||
| override: true, | ||
| only: :test, | ||
| runtime: false}, |
There was a problem hiding this comment.
this runtime: false shouldn't be there in test deps
lib/demuxer.ex
Outdated
|
|
||
| buffer_action = | ||
| {:buffer, | ||
| {pad, %Buffer{payload: packet.payload, metadata: %{ogg_page_pts: packet.ogg_page_pts}}}} |
There was a problem hiding this comment.
Suggested change
| {pad, %Buffer{payload: packet.payload, metadata: %{ogg_page_pts: packet.ogg_page_pts}}}} | |
| {pad, %Buffer{payload: packet.payload, metadata: %{ogg: %{page_pts: packet.ogg_page_pts}}}}} |
There was a problem hiding this comment.
let's describe the metadata added to buffers in the moduledoc
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows this element to get the pts of first completed packet in each ogg page. They are then put in the buffer's metadata under field
ogg_page_ptsto be used by the Opus parser