Add HEVC muxing support for CMAF #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
reviewed
Nov 21, 2023
Comment on lines
330
to
332
| defp key_frame?(%{metadata: %{h264: %{key_frame?: true}}}), do: true | ||
| defp key_frame?(%{metadata: %{h265: %{key_frame?: true}}}), do: true | ||
| defp key_frame?(_sample), do: false |
There was a problem hiding this comment.
Seems like this kind of function is repeated many times, maybe let's add a codec_helper.ex and put it there? I guess it should accept just the metadata to be most flexible.
There was a problem hiding this comment.
I added the function to the already existing Membrane.MP4.Helper module.
mat-hek
approved these changes
Nov 28, 2023
|
@gBillal thanks, next time don't forget to refresh my review, otherwise I don't know the PR's ready ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.