Don't fail when unknown sample types are encountered #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s 0 (as the specification defines. Ignore unsupported sample types. Add tests checking if unsupported sample types are ignored
FelonEkonom
reviewed
Jul 26, 2024
lib/membrane_mp4/demuxer/isom.ex
Outdated
Comment on lines
654
to
657
| |> Enum.filter(fn {_track_id, table} -> | ||
| table.sample_description == nil | ||
| end) | ||
| |> length() |
There was a problem hiding this comment.
You can use https://hexdocs.pm/elixir/1.12/Enum.html#count/2
lib/membrane_mp4/demuxer/isom.ex
Outdated
| @@ -512,12 +519,14 @@ defmodule Membrane.MP4.Demuxer.ISOM do | |||
| defp sample_description_to_kind(%Membrane.H265{}), do: :video | |||
| defp sample_description_to_kind(%Membrane.AAC{}), do: :audio | |||
| defp sample_description_to_kind(%Membrane.Opus{}), do: :audio | |||
| defp sample_description_to_kind(_other), do: :unknown | |||
There was a problem hiding this comment.
Is the new case used anywhere?
There was a problem hiding this comment.
it's indeed not used, I will remove it
FelonEkonom
approved these changes
Jul 26, 2024
mat-hek
reviewed
Jul 29, 2024
lib/membrane_mp4/demuxer/isom.ex
Outdated
Comment on lines
435
to
436
| |> Enum.reject(fn {_track_id, table} -> table.sample_description == nil end) | ||
| |> Enum.into(%{}) |
There was a problem hiding this comment.
Suggested change
| |> Enum.reject(fn {_track_id, table} -> table.sample_description == nil end) | |
| |> Enum.into(%{}) | |
| |> Map.reject(fn {_track_id, table} -> table.sample_description == nil end) |
There was a problem hiding this comment.
And let's extract it to a separate function
mat-hek
approved these changes
Jul 31, 2024
Co-authored-by: Mateusz Front <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
tcmdsamples)stszentry list is read only whensample_sizeequals 0 (as defined in the specification)