Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for version1 boxes. #109

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Add support for version1 boxes. #109

merged 4 commits into from
Apr 25, 2024

Conversation

varsill
Copy link
Contributor

@varsill varsill commented Apr 18, 2024

This PR:

  • adds support for parsing boxes based on the version field
  • adds parsing of co64 box
  • allows to specify separately field and the mask in the :when clause of the parser

@varsill varsill requested a review from mat-hek as a code owner April 18, 2024 12:35
Copy link
Member

@mat-hek mat-hek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the API could look like

modification_time: {:uint32, when: {:version, value: 0}},
sample_offset: {:uint32, when: {:fo_flags, mask: 0x800}}

we wouldn't have to support passing both at the same time

@varsill varsill requested a review from mat-hek April 23, 2024 15:11
@varsill varsill merged commit 7c58255 into master Apr 25, 2024
3 checks passed
@varsill varsill deleted the add_version_1_boxes branch April 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants