Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pts in Membrane.Buffer instead of timestamp in metadata #10

Merged
merged 1 commit into from
May 16, 2022

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented May 5, 2022

No description provided.

@mickel8 mickel8 self-assigned this May 5, 2022
@mickel8 mickel8 requested a review from mat-hek May 5, 2022 14:48
buffer_1 = %Buffer{payload: @frame, metadata: %{timestamp: 0}}
buffer_2 = %Buffer{payload: @frame, metadata: %{timestamp: 100_000_000 <|> 3}}
buffer_1 = %Buffer{payload: @frame, pts: 0}
buffer_2 = %Buffer{payload: @frame, pts: 100_000_000 <|> 3}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we no longer accept ratio as the timestamp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created issue for this - MV-71

@mickel8 mickel8 merged commit 5d0f97f into master May 16, 2022
@mickel8 mickel8 deleted the fix-tests branch May 16, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants