Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATEAM-13094]: Implement Alibaba OSS backend #223

Merged
merged 15 commits into from
Sep 14, 2022
Merged

[ATEAM-13094]: Implement Alibaba OSS backend #223

merged 15 commits into from
Sep 14, 2022

Conversation

kadetutu
Copy link
Contributor

@kadetutu kadetutu commented Sep 12, 2022

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Fixes [#65] (#65) Add Alibaba OSS Storage Backend
Is your feature request related to a problem? Please describe.

As a user of the Alibaba Cloud, I want to use Alibaba OSS Storage to persist my cache, so that I can reuse the storage system that I already know.

Describe the solution you'd like
Alibaba OSS Storage Backend

Describe alternatives you've considered
using a separate storage backend that already exists in drone-cache

Additional context
none

Proposed Changes

  • Implemented Alibaba OSS backend storage for caching
  • Updated relevant codes for the addition of alioss backend module
  • Updated ReadMe file to reflect new addition

Description

  • Added alioss module with functions to implement backend storage interface using aliyun SDK
  • Updated Backend package config with settings for alioss configurations
  • Updated plugin CLI flags with options for alioss
  • Updated ReadMe file to reflect newly added storage backend (Alibaba OSS)

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date.

@kadetutu kadetutu merged commit 299a9e5 into master Sep 14, 2022
@kadetutu kadetutu deleted the ateam-14094 branch September 14, 2022 15:49
@spier
Copy link
Contributor

spier commented Sep 15, 2022

Great work @kadetutu and @bdebyl !

Should we also list the Alibaba OSS Storage Backend in the documentation here:
https://github.com/meltwater/drone-cache#supported-storage-backends

@kadetutu
Copy link
Contributor Author

Thanks @spier for pointing this out. I will work on updating the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants