Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taps): Tap developers can now disable HTTP redirects #2433

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 17, 2024

@edgarrmondragon edgarrmondragon changed the title feat(taps): Tap developers can now disable redirects feat(taps): Tap developers can now disable HTTP redirects May 17, 2024
Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #2433 will not alter performance

Comparing 883-feature-allow-rest-tap-developers-to-configure-whether-redirects-should-be-allowed (625b3cb) with main (b524ad1)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (22b2065) to head (625b3cb).
Report is 143 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2433   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files          54       54           
  Lines        4788     4789    +1     
  Branches      936      936           
=======================================
+ Hits         4270     4271    +1     
  Misses        361      361           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 883-feature-allow-rest-tap-developers-to-configure-whether-redirects-should-be-allowed branch from f4f624e to 625b3cb Compare May 17, 2024 01:42
@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 17, 2024 01:49
@edgarrmondragon edgarrmondragon merged commit e0c5dfd into main May 17, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the 883-feature-allow-rest-tap-developers-to-configure-whether-redirects-should-be-allowed branch May 17, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow REST tap developers to configure whether redirects should be allowed
1 participant