fix: converting floats to decimals before schema validation #2041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a known challenge with certain validations of floating points using JSON schema, by converting floats to decimals prior to validation.
For example, this fixes errors like:
There is a relevant discussion here: https://gitlab.com/meltano/target-csv/-/issues/3
Certain targets (for example: gupy-io/target-s3-parquet) rely on this project to do schema validation, so by handling this here, developers can continue to use that pattern while also avoiding these challenges with floating point validation.
📚 Documentation preview 📚: https://meltano-sdk--2041.org.readthedocs.build/en/2041/