-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support custom JSON schema validation and string format checkers in targets #1471
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1471 +/- ##
==========================================
+ Coverage 85.05% 87.94% +2.88%
==========================================
Files 58 59 +1
Lines 4845 7417 +2572
Branches 805 1642 +837
==========================================
+ Hits 4121 6523 +2402
- Misses 526 642 +116
- Partials 198 252 +54 ☔ View full report in Codecov by Sentry. |
c8f6b33
to
188a622
Compare
188a622
to
c1a8177
Compare
@edgarrmondragon I like it so far. No format checking at all to start and then you can add checks as you need them. When working with this I added a default format checker that I knew would fail
|
This reverts commit 5791b62.
229306b
to
33b43a1
Compare
Related: #1831 |
CodSpeed Performance ReportMerging #1471 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BuzzCutNorman Do you think this is still relevant? The original implementation was rather specific python-jsonschema
so I wonder if we should keep it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgarrmondragon If you would please clarify if the question of relevance is about test_format_checker.py
or the PR in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BuzzCutNorman I commented on the file in the wrong PR 😅. I meant #2136 (comment)
📚 Documentation preview 📚: https://meltano-sdk--1471.org.readthedocs.build/en/1471/