Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not ignore jsonschema in mypy checks #1456

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 24, 2023

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1456 (6d2635b) into main (1a79462) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
- Coverage   85.47%   85.46%   -0.01%     
==========================================
  Files          57       57              
  Lines        4763     4760       -3     
  Branches      808      809       +1     
==========================================
- Hits         4071     4068       -3     
  Misses        501      501              
  Partials      191      191              
Impacted Files Coverage Δ
singer_sdk/_singerlib/schema.py 100.00% <ø> (ø)
singer_sdk/plugin_base.py 76.74% <100.00%> (-0.40%) ⬇️
singer_sdk/typing.py 94.94% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

singer_sdk/plugin_base.py Show resolved Hide resolved
@edgarrmondragon edgarrmondragon merged commit 82b15da into main Feb 24, 2023
@edgarrmondragon edgarrmondragon deleted the chore/mypy-jsonschema branch February 24, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants