Skip to content

Commit

Permalink
Merge branch 'main' into 1121-bug-replication-key-should-not-be-requi…
Browse files Browse the repository at this point in the history
…red-for-log-based-method
  • Loading branch information
edgarrmondragon authored Nov 1, 2022
2 parents 4f98e29 + 81ec6ac commit 2310063
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 79 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ repos:
files: 'singer_sdk/.*'

- repo: https://github.com/asottile/pyupgrade
rev: v3.1.0
rev: v3.2.0
hooks:
- id: pyupgrade
args: [--py37-plus]
Expand Down
2 changes: 1 addition & 1 deletion docs/batch.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class MySink(Sink):
# process the batch files
```

## Known Limitations
## Known Limitations of `BATCH`

1. Currently the built-in `BATCH` implementation does not support incremental bookmarks or `STATE` tracking. This work is tracked in [Issue #976](https://github.com/meltano/sdk/issues/976).
2. The `BATCH` implementation is not currently compatible with [Stream Maps](https://sdk.meltano.com/en/latest/stream_maps.html). This is certainly possible to implement in theory, but it would also introduce some performance penalties. This limitation is tracked in [Issue 1117#](https://github.com/meltano/sdk/issues/1117).
Expand Down
Loading

0 comments on commit 2310063

Please sign in to comment.