Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial devcontainer config #1139

Closed

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Jan 29, 2023

@aaronsteers aaronsteers linked an issue Jan 29, 2023 that may be closed by this pull request
@aaronsteers aaronsteers temporarily deployed to preview January 29, 2023 03:29 — with GitHub Actions Inactive
@netlify
Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 249c137
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/63d7172c4f247c00091c8e65
😎 Deploy Preview https://deploy-preview-1139--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aaronsteers aaronsteers temporarily deployed to preview January 29, 2023 03:30 — with GitHub Actions Inactive
@aaronsteers aaronsteers temporarily deployed to preview January 30, 2023 01:02 — with GitHub Actions Inactive
@aaronsteers aaronsteers enabled auto-merge (squash) January 30, 2023 01:03
@aaronsteers aaronsteers temporarily deployed to preview January 30, 2023 01:04 — with GitHub Actions Inactive
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error because of --openssl-legacy-provider being in $NODE_OPTIONS. Why was this option set @aaronsteers?

[173931 ms] Container server: /home/node/.vscode-server/bin/97dec172d3256f8ca4bfb2143f3f76b503ca0534/node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
[173957 ms] Command failed: /home/node/.vscode-server/bin/97dec172d3256f8ca4bfb2143f3f76b503ca0534/bin/code-server --log debug --force-disable-user-env --server-data-dir /home/node/.vscode-server --use-host-proxy --telemetry-level off --accept-server-license-terms --host 127.0.0.1 --port 0 --connection-token-file /home/node/.vscode-server/data/Machine/.connection-token-97dec172d3256f8ca4bfb2143f3f76b503ca0534 --extensions-download-dir /home/node/.vscode-server/extensionsCache --install-extension dbaeumer.vscode-eslint --install-extension ms-python.python --install-extension ms-python.vscode-pylance --install-extension Vue.volar --start-server --disable-websocket-compression

@aaronsteers
Copy link
Contributor Author

aaronsteers commented Jan 31, 2023

I'm getting an error because of --openssl-legacy-provider being in $NODE_OPTIONS. Why was this option set @aaronsteers?

[173931 ms] Container server: /home/node/.vscode-server/bin/97dec172d3256f8ca4bfb2143f3f76b503ca0534/node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
[173957 ms] Command failed: /home/node/.vscode-server/bin/97dec172d3256f8ca4bfb2143f3f76b503ca0534/bin/code-server --log debug --force-disable-user-env --server-data-dir /home/node/.vscode-server --use-host-proxy --telemetry-level off --accept-server-license-terms --host 127.0.0.1 --port 0 --connection-token-file /home/node/.vscode-server/data/Machine/.connection-token-97dec172d3256f8ca4bfb2143f3f76b503ca0534 --extensions-download-dir /home/node/.vscode-server/extensionsCache --install-extension dbaeumer.vscode-eslint --install-extension ms-python.python --install-extension ms-python.vscode-pylance --install-extension Vue.volar --start-server --disable-websocket-compression

@WillDaSilva We can remove it. I was getting other errors, which this env var seemed to resolve. I'm going to revert this to draft status while we figure out a path forward.

If you are able to get something working smoothly, feel free to contribute back commits to this PR.

@aaronsteers aaronsteers disabled auto-merge January 31, 2023 19:10
@aaronsteers aaronsteers marked this pull request as draft January 31, 2023 19:10
@aaronsteers
Copy link
Contributor Author

aaronsteers commented Feb 1, 2023

Very relevant to performance for first-run and subsequent runs...

Hi 👋

We are expecting that the Features are cached, however, there is a regression. There's a PR to fix this in review --> devcontainers/cli#382

This should get fixed soon! 😄

Related: should I expect that Prebuilds feature would include features' installations if enabled?

Are you referring to Codespaces prebuilt? If so, then yes.

An outstanding regression affects performance of features delivery for decontainers:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add devcontainer config for Hub contributions
3 participants