Skip to content

Commit

Permalink
Fix primefaces#6855: ConfirmDialog group missing from typescript
Browse files Browse the repository at this point in the history
  • Loading branch information
melloware committed Aug 21, 2024
1 parent 34229f9 commit 755ff40
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
4 changes: 4 additions & 0 deletions components/lib/confirmdialog/confirmdialog.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ interface ConfirmDialogOptions {
* @group Properties
*/
export interface ConfirmDialogProps extends Omit<DialogProps, 'onHide' | 'footer' | 'pt'> {
/**
* Optional key to match the key of the confirmation, useful to target a specific confirm dialog instance.
*/
group?: string | undefined;
/**
* Unique tag key used to separate the confirmDialog components in the page.
*/
Expand Down
10 changes: 3 additions & 7 deletions components/lib/panelmenu/PanelMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,9 @@ export const PanelMenu = React.memo(
},
getPTOptions(item, 'headerSubmenuIcon', index)
);

const submenuIcon = item.items && IconUtils.getJSXIcon(
active
? (props.collapseIcon || <ChevronDownIcon {...headerSubmenuIconProps} />)
: (props.expandIcon || <ChevronRightIcon {...headerSubmenuIconProps} />)
);


const submenuIcon = item.items && IconUtils.getJSXIcon(active ? props.collapseIcon || <ChevronDownIcon {...headerSubmenuIconProps} /> : props.expandIcon || <ChevronRightIcon {...headerSubmenuIconProps} />);

const headerLabelProps = mergeProps(
{
className: cx('headerLabel')
Expand Down
8 changes: 2 additions & 6 deletions components/lib/panelmenu/PanelMenuSub.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,8 @@ export const PanelMenuSub = React.memo(
getPTOptions(processedItem, 'submenuicon', index)
);

const submenuIcon = item.items && IconUtils.getJSXIcon(
active
? (props.collapseIcon || <ChevronDownIcon {...submenuIconProps} />)
: (props.expandIcon || <ChevronRightIcon {...submenuIconProps} />)
);

const submenuIcon = item.items && IconUtils.getJSXIcon(active ? props.collapseIcon || <ChevronDownIcon {...submenuIconProps} /> : props.expandIcon || <ChevronRightIcon {...submenuIconProps} />);

const submenu = createSubmenu(processedItem, active);
const actionProps = mergeProps(
{
Expand Down

0 comments on commit 755ff40

Please sign in to comment.