Fix primefaces#7483: Toast/Message handle remove by id 0

melloware · Dec 6, 2024 · 43ac55c · 43ac55c
1 parent 60e27a0
commit 43ac55c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/components/lib/messages/Messages.js b/components/lib/messages/Messages.js
@@ -73,7 +73,7 @@ export const Messages = React.memo(
 
         const remove = (messageInfo) => {
             // allow removal by ID or by message equality
-            const removeMessage = messageInfo._pId ? messageInfo._pId : messageInfo.message || messageInfo;
+            const removeMessage = ObjectUtils.isNotEmpty(messageInfo._pId) ? messageInfo._pId : messageInfo.message || messageInfo;
 
             setMessagesState((prev) => prev.filter((msg) => msg._pId !== messageInfo._pId && !ObjectUtils.deepEquals(msg.message, removeMessage)));
 

diff --git a/components/lib/toast/Toast.js b/components/lib/toast/Toast.js
@@ -76,7 +76,7 @@ export const Toast = React.memo(
 
         const remove = (messageInfo) => {
             // allow removal by ID or by message equality
-            const removeMessage = messageInfo._pId ? messageInfo._pId : messageInfo.message || messageInfo;
+            const removeMessage = ObjectUtils.isNotEmpty(messageInfo._pId) ? messageInfo._pId : messageInfo.message || messageInfo;
 
             setMessagesState((prev) => prev.filter((msg) => msg._pId !== messageInfo._pId && !ObjectUtils.deepEquals(msg.message, removeMessage)));