Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility to React Native's feature requests issue #214

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Add visibility to React Native's feature requests issue #214

merged 2 commits into from
Nov 13, 2017

Conversation

florentroques
Copy link
Contributor

Proposal:
Add link to React Native's feature requests issue to readme so that more people see it and vote!!

Proposal:
Add link to React Native's feature requests issue to readme so that more people see it and vote!!
README.md Outdated
@@ -11,6 +11,10 @@ Swiper component for React Native featuring **previews**, **snapping effect**, *

-----

### Do you want a better plugin? [Vote for React Native's feature requests](https://github.com/archriss/react-native-snap-carousel/issues/203)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florentroques Do you mind modifying it to the following? A small emoji and a bit of clarification cannot harm ;-)

### :sparkles: Do you want an even better plugin? [Vote for React Native's feature requests](https://github.com/archriss/react-native-snap-carousel/issues/203) to let the Facebook team know what they need to improve!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@florentroques
Copy link
Contributor Author

done :-) thank you

@bd-arc bd-arc merged commit 31f91cf into meliorence:master Nov 13, 2017
@bd-arc
Copy link
Contributor

bd-arc commented Nov 13, 2017

Thank you ;-)

I know nothing about your other suggestion: is it possible to display a message in the console when users install the plugin via npm or yarn?

@florentroques
Copy link
Contributor Author

I've suggested this as I thought it was a good idea but don't actually know its feasibility yet ^_^
Looking into it!

@florentroques
Copy link
Contributor Author

I've looked into displaying a message after the plugin has been installed via npm or yarn.

The hook to use is postinstall, apparently it's only possible if the user uses npm not yarn (security issues) (from yarnpkg/yarn#721 (comment))

By default, npm also allows developers who write these packages to execute other code that’s needed as part of the install process. That creates security issues, though, so Yarn does not have this feature.

-- Source

Here's what it does

screen shot 2017-11-13 at 18 10 33

screen shot 2017-11-13 at 18 10 05

Here's a test repo https://github.com/florentroques/npm-package-test-postinstall

I open a pull request to implement this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants