-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow text to be selected and copied #85
Conversation
Hi, |
@Exilz Hi. so copy/paste works to the extend of what React-Native currently supports. |
Just to be clear, the bug that was reported still happens, although I think that is more of a feature request than a bug. This change should enable the developers to enable whatever React Native currently support for copying text on a |
@Exilz Any more actions you think should be done with this one? Are we ready to merge it or does it not make sense to do this? |
Well... it can't hurt, and if someone finds some use to it, that's great. I'll merge with the next release, I might have some improvements to add to default renderers, so it might take a couple of days. Hopefully, react-native will improve its |
@Exilz Sounds good to me. Thanks! And 👍 on |
Merged in |
Which props one should use to enable ability to select and copy text? |
@code-by depends on the versions. 4.x : |
but one could select text only inside one |
@code-by This is unfortunately a limitation of Android, in which selection can only happen in the same You could eventually provide your own control to select all the content, but I see no trivial way to do this. |
I found that on iOS there no selection, only ability to copy whole text, that's right? |
|
This uses the
react-native
's ownselectable
prop onText
component and allow the same behavior as ifselectable
is enabled on a normalText
component.This also adds default styles for
strikethrough
(i.e.<s>...</s>
) that is currently not supported.This should address #58