Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to re-enable percy once they support shadow dom #934

Open
melink14 opened this issue Apr 2, 2022 · 1 comment
Open

Attempt to re-enable percy once they support shadow dom #934

melink14 opened this issue Apr 2, 2022 · 1 comment
Labels
Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs)

Comments

@melink14
Copy link
Owner

melink14 commented Apr 2, 2022

Since shadow dom is required for rikaikun to work well and direct visual screenshot testing is working well I will disable percy until they add support in the future.

See percy/cli#280
melink14 added a commit that referenced this issue Apr 2, 2022
@melink14
test(ui): Remove percy from e2e testing stack
a365083 
Percy has no way to capture shadow DOM and it's not worth complicating the code for the forseeable future. See #934 for more info.
@melink14 melink14 mentioned this issue Apr 2, 2022
Merged
melink14 added a commit that referenced this issue Apr 2, 2022
@melink14
test(ui): Remove percy from e2e testing stack
f391726 
Percy has no way to capture shadow DOM and it's not worth complicating the code for the forseeable future. See #934 for more info.
melink14 added a commit that referenced this issue Apr 2, 2022
@melink14
test(ui): Remove percy from e2e testing stack (#935)
2bebda8 
Percy has no way to capture shadow DOM and it's not worth complicating the code for the forseeable future. See #934 for more info.
@melink14
Copy link
Owner Author

Thye added early shadow dom support so this is possible now!
https://docs.percy.io/docs/shadow-dom

@melink14 melink14 added the Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs) label Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@melink14