Skip to content

Commit

Permalink
test(ui): Use 立 instead of 人 for kanji entry test (#932)
Browse files Browse the repository at this point in the history
* test(ui): Use 立 instead of 人 for kanji entry test

人 does not have any verb forms meaning the display of the extra furigana isn't tested.

* test(visual): Update baselines with new screenshots

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
melink14 and github-actions[bot] authored Apr 2, 2022
1 parent b7013ce commit 7c833c9
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions extension/test/e2e_visual_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,13 @@ describe('Visual Regression Tests', function () {
await updateConfiguration({ popupcolor: color });
const clock = sinon.useFakeTimers();
const span = insertHtmlIntoDomAndReturnFirstTextNode(
'<span></span>'
'<span></span>'
) as HTMLSpanElement;

await triggerMousemoveAtElementStart(span);
// Tick the clock forward to account for the popup delay.
clock.tick(150);
await waitForVisiblePopup();
await sendKeys({ press: 'Shift' });

await takeSnapshot(`kanji-entries-${color}`);
});
Expand Down
Binary file modified screenshots/Chromium/baseline/kanji-entries-black.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified screenshots/Chromium/baseline/kanji-entries-blue.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified screenshots/Chromium/baseline/kanji-entries-lightblue.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified screenshots/Chromium/baseline/kanji-entries-yellow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 7c833c9

Please sign in to comment.