Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filtering and labeling by relationship type for item-piechart #283

Merged
merged 23 commits into from
Jul 4, 2022

Conversation

JasperCraeghs
Copy link
Member

@JasperCraeghs JasperCraeghs commented Jun 30, 2022

  • Added :sourcetype: option to the item-piechart directive
  • Added :targettype: option to the item-piechart directive
  • Fixed a bug that resulted in using the <<attribute>> value of the nested target item that was parsed last as label instead of respecting the order of the arguments of the :<<attribute>>: option, or, in case of multiple target items, discarding the effect of those defined first.

Resolves #270

@JasperCraeghs JasperCraeghs changed the title WIP: Support filtering by relationship type for item-piechart WIP: Support filtering and labelling by relationship type for item-piechart Jun 30, 2022
@JasperCraeghs JasperCraeghs changed the title WIP: Support filtering and labelling by relationship type for item-piechart WIP: Support filtering and labeling by relationship type for item-piechart Jun 30, 2022
@JasperCraeghs
Copy link
Member Author

JasperCraeghs commented Jun 30, 2022

Which label shall be used for an RQT-item that is linked to two TEST-items, of which only one is linked to a TEST_REP-item? covered or executed? The current implementation on master branch is not consistent and depends on the order in which the targets are defined.

.. item-piechart::
    :id_set: RQT TEST TEST_REP
    :label_set: uncovered, covered, executed

@bavovanachte
Copy link
Member

I would say "covered" specifically in the case of test coverage. I haven't used the item-piechart directive yet, but from the documentation, I understand that "covered" in this case would mean that the REQ has a TEST linked, but not a test report.

I would think it's deceiving to mark a requirement as "executed" if only one of its testcases has been run. I'm guessing requirements with multiple testcases is not uncommon, and my opinion would be that a requirement is only covered if all of its planned testcases have been executed

@Juegadamas
Copy link

I'm with @bavovanachte. I'd say covered for the same reasons.

@JasperCraeghs JasperCraeghs changed the title WIP: Support filtering and labeling by relationship type for item-piechart Support filtering and labeling by relationship type for item-piechart Jul 1, 2022
doc/usage.rst Outdated Show resolved Hide resolved
@Letme Letme merged commit 39cb23b into master Jul 4, 2022
@Letme Letme deleted the piechart-fileting branch July 4, 2022 08:23
Letme added a commit that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

item-piechart: filter by relationship between source and target
4 participants