Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and add configurability for Jira issue link types; bug fixes #33

Merged
merged 11 commits into from
Dec 13, 2023

Conversation

JasperCraeghs
Copy link
Member

@JasperCraeghs JasperCraeghs commented Dec 7, 2023

  • Support link type Blocks, configured by Atlassian for Jira Cloud.
  • Add input argument [-L [LINKS ...]] to override the default configuration of Jira issue link types to take into account for TaskJuggler's depends keyword
  • Validate existence of the aforementioned the configuration of Jira issue link types by retrieving all issue link types from the Jira instance
  • Fix a rare and old bug that occurred when a task depends on two tasks with estimate of 0m successively, causing KeyError in if not id_to_task_map[identifier].is_resolved:
  • Fix duplicate tasks for depends, resulting in an error by TaskJuggler: Error in scenario plan: No need to specify dependency X multiple times for task Y.

Closes #32

@JasperCraeghs JasperCraeghs requested a review from Ben2022 December 7, 2023 18:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a83831) 95.01% compared to head (6b642b6) 95.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   95.01%   95.17%   +0.15%     
==========================================
  Files           1        1              
  Lines         281      290       +9     
==========================================
+ Hits          267      276       +9     
  Misses         14       14              
Flag Coverage Δ
unittests 95.17% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ben2022
Copy link
Contributor

Ben2022 commented Dec 8, 2023

Thanks a lot. It looks good. Let's test it in real like with Bert.

@JasperCraeghs JasperCraeghs changed the title WIP: Configurable link types WIP: Validate and add configurability for Jira issue link types; bug fixes Dec 12, 2023
@JasperCraeghs JasperCraeghs changed the title WIP: Validate and add configurability for Jira issue link types; bug fixes Validate and add configurability for Jira issue link types; bug fixes Dec 12, 2023
@0xBDEF
Copy link

0xBDEF commented Dec 13, 2023

@JasperCraeghs : I reviewed and tested it. It is OK according to me. I can not approve, so will you ask @Ben2022 to approve or do you make me the approver?

Copy link
Contributor

@Ben2022 Ben2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Bert

@Ben2022 Ben2022 merged commit 50a7dd3 into master Dec 13, 2023
6 checks passed
@Ben2022 Ben2022 deleted the configurable-link-types branch December 13, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depends not created when JIRA issue uses "is blocked by" other issue
4 participants