Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Jira link with name 'Dependent' #30

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Support the Jira link with name 'Dependent' #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9552fc6
Support the new 'Dependent' Jira link
JasperCraeghs Apr 12, 2023
04a9c1b
Update GitHub actions and use codecov/codecov-action@v3
JasperCraeghs Apr 12, 2023
b5ef7c7
Remove rule for removed codecov Python package
JasperCraeghs Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand All @@ -22,9 +22,15 @@ jobs:
python -m pip install tox tox-gh-actions
- name: Run test
run: tox -e py
- name: Codecov
- name: Upload coverage to Codecov
if: matrix.python-version == 3.9
run: tox -e codecov
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./coverage.xml
fail_ci_if_error: true
flags: unittests
verbose: true
- name: Static checks
if: matrix.python-version == 3.9
run: tox -e check
Expand All @@ -35,9 +41,9 @@ jobs:
needs: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: '3.7'
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion src/mlx/jira_juggler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def load_from_jira_issue(self, jira_issue):
for link in jira_issue.fields.issuelinks:
if hasattr(link, 'inwardIssue') and link.type.name == 'Blocker':
self.append_value(to_identifier(link.inwardIssue.key))
if hasattr(link, 'outwardIssue') and link.type.name == 'Dependency':
if hasattr(link, 'outwardIssue') and link.type.name in ('Dependency', 'Dependent'):
self.append_value(to_identifier(link.outwardIssue.key))

def validate(self, task, tasks):
Expand Down
13 changes: 2 additions & 11 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ basepython =
py39: {env:TOXPYTHON:python3.9}
py310: {env:TOXPYTHON:python3.10}
py311: {env:TOXPYTHON:python3.11}
{clean,check,report,coveralls,codecov}: python3
{clean,check,report,coveralls}: python3
setenv =
PYTHONPATH={toxinidir}/tests
PYTHONUNBUFFERED=yes
Expand All @@ -35,7 +35,7 @@ deps =
pip>=20.3.4
parameterized
commands =
{posargs:py.test --cov --cov-report=term-missing -vv tests}
pytest --cov-report=term-missing --cov-report=xml -vv --cov tests

[testenv:check]
deps =
Expand All @@ -58,15 +58,6 @@ skip_install = true
commands =
coveralls []

[testenv:codecov]
deps =
codecov
skip_install = true
commands =
coverage xml --ignore-errors
codecov []


[testenv:report]
deps = coverage
skip_install = true
Expand Down