better for codegen formatting (#1275)

* better `for` codegen formatting * fix tests * chore: add changelog entry
melange-re · Jan 6, 2025 · 293ba2b · 293ba2b
1 parent 61a6ed1
commit 293ba2b
Show file tree

Hide file tree

Showing 76 changed files with 262 additions and 258 deletions.
diff --git a/Changes.md b/Changes.md
@@ -80,6 +80,8 @@ Unreleased
 - BREAKING: ppx: print the `deprecated` alert for `@@deriving abstract` at the
   declaration site rather than at (all) usages
   ([#1269](https://github.com/melange-re/melange/pull/1269))
+- core: prettify melange code generation for `for` loops
+  ([#1275](https://github.com/melange-re/melange/pull/1275))
 
 4.0.1 2024-06-07
 ---------------

diff --git a/jscomp/core/js_dump.ml b/jscomp/core/js_dump.ml
@@ -1108,6 +1108,7 @@ and statement_desc top cxt (s : J.statement_desc) : cxt =
               group cxt 0 (fun () ->
                   (* The only place that [semi] may have semantics here *)
                   string cxt L.for_;
+                  space cxt;
                   paren_group cxt 1 (fun () ->
                       let cxt, new_id =
                         match
@@ -1166,6 +1167,7 @@ and statement_desc top cxt (s : J.statement_desc) : cxt =
                       pp_direction cxt direction;
                       ident cxt id))
             in
+            space cxt;
             brace_block cxt s)
       in
       action cxt

diff --git a/jscomp/test/dist/jscomp/test/406_primitive_test.js b/jscomp/test/dist/jscomp/test/406_primitive_test.js
diff --git a/jscomp/test/dist/jscomp/test/array_test.js b/jscomp/test/dist/jscomp/test/array_test.js
diff --git a/jscomp/test/dist/jscomp/test/bal_set_mini.js b/jscomp/test/dist/jscomp/test/bal_set_mini.js
diff --git a/jscomp/test/dist/jscomp/test/bdd.js b/jscomp/test/dist/jscomp/test/bdd.js
diff --git a/jscomp/test/dist/jscomp/test/bench.js b/jscomp/test/dist/jscomp/test/bench.js
diff --git a/jscomp/test/dist/jscomp/test/bs_MapInt_test.js b/jscomp/test/dist/jscomp/test/bs_MapInt_test.js
diff --git a/jscomp/test/dist/jscomp/test/bs_array_test.js b/jscomp/test/dist/jscomp/test/bs_array_test.js
diff --git a/jscomp/test/dist/jscomp/test/bs_hashmap_test.js b/jscomp/test/dist/jscomp/test/bs_hashmap_test.js
diff --git a/jscomp/test/dist/jscomp/test/bs_hashset_int_test.js b/jscomp/test/dist/jscomp/test/bs_hashset_int_test.js
diff --git a/jscomp/test/dist/jscomp/test/bs_hashtbl_string_test.js b/jscomp/test/dist/jscomp/test/bs_hashtbl_string_test.js
diff --git a/jscomp/test/dist/jscomp/test/bs_list_test.js b/jscomp/test/dist/jscomp/test/bs_list_test.js
diff --git a/jscomp/test/dist/jscomp/test/bs_map_set_dict_test.js b/jscomp/test/dist/jscomp/test/bs_map_set_dict_test.js