Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ documentation widget #160

Merged
merged 11 commits into from
Apr 26, 2024
Merged

feat: ✨ documentation widget #160

merged 11 commits into from
Apr 26, 2024

Conversation

melMass
Copy link
Owner

@melMass melMass commented Mar 22, 2024

Since months (#1438) the DESCRIPTION field of python classes is passed to litegraph, yet nothing is used.

This PR introduces a shared method to add a documentation widget to any nodeType, this makes it usable by other extensions.
It only affects mtb nodes by default and it also reads the class __doc__ field as a fallback for DESCRIPTION:

  • cleanup the code
  • For now I decided to source from the Github wiki, so I submoduled it other fallback approach? As the animation builder example, inlining doc is not ideal, maybe source/parse from a md file? Like extrRoot/doc.md
  • proper resizing handling: At first doc was over the node, but after a few tests and feedback from others I changed it to the side but the sizing is now messed up.

dok+++

Amorano added a commit to Amorano/Jovimetrix that referenced this pull request Mar 23, 2024
melMass added 8 commits April 21, 2024 17:01
also properly print to console now...
For now supports:

- number (int/float)
- string
- vector (2, 3, 4)
- color (serialised as HEX)
This requires this PR to be merged:
comfyanonymous/ComfyUI#3329

There is a trick to make it work without that PR but it
feels very hacky, the code for it is kept for reference but unused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant