Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digital Miner dupe bug #5449

Closed
focamacho opened this issue May 2, 2019 · 2 comments · Fixed by #5451
Closed

Digital Miner dupe bug #5449

focamacho opened this issue May 2, 2019 · 2 comments · Fixed by #5451
Labels
bug Fixed in dev
Milestone
9.7.4

Comments

@focamacho
Copy link

Issue description:
You can duplicate items using a Digital Miner

Steps to reproduce:

  1. Place a Digital Miner in the ground
  2. Put items inside a stackable block that holds items in after being broken(Like RFTools Crafter)
  3. Put more "RFTools Crafters" in the ground
  4. Set a filter in the Digital Miner to mine the Crafters(Fuzzy Mode:ON)
  5. Turn on the digital miner
  6. All the collected crafters by the miner will be the same as the first (See the video for more info)

Version (make sure you are on the latest version before reporting):
Forge: 1.12.2 - 14.23.5.2836
Mekanism: Mekanism-1.12.2-9.7.3.374

If a (crash)log is relevant for this issue, link it here:

https://www.youtube.com/watch?v=IKg_pf44QBo
@pupnewfster pupnewfster added this to the 9.7.4 milestone May 2, 2019
@pupnewfster pupnewfster added the bug label May 2, 2019
@Zajozor
Copy link
Contributor

Zajozor commented May 2, 2019

Seems related to the same problem as #5435

thiakil added a commit that referenced this issue May 3, 2019
@thiakil
fix bad stacking check for Digital Miner. #5449
f8d9d4d
@thiakil thiakil mentioned this issue May 3, 2019
Merged
@thiakil
Copy link
Member

thiakil commented May 4, 2019

confirmed fixed in #5451

pupnewfster pushed a commit that referenced this issue May 4, 2019
@thiakil @pupnewfster
Improve Itemstack equality checks (#5451)
4c4e88d 
* fix bad stacking check for Digital Miner. #5449

* map to forge's stack stackability check so caps are accounted for

* check nbt when taking a defined item

* fix bad reference equality check for empty

* Switch sorting to using our stackable method

* Fix bad stack check for robit #5454

* Improve stack compare for robit smelting
@pupnewfster pupnewfster mentioned this issue May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixed in dev
Projects
None yet
Milestone
9.7.4
Development

Successfully merging a pull request may close this issue.

Itemstack equality mekanism/Mekanism
4 participants
@pupnewfster @thiakil @Zajozor @focamacho