Add total field to get-tasks route #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding unit tests, since other tests enqueue tasks, the total returned from the API will be different each time. Adding a |
|
@Kerollmops Could you please take a look? Thanks! |
Kerollmops
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
That's simple and perfect 👌 Thank you!
I'll let @irevoire merge this!
meili-bors bot
added a commit
that referenced
this pull request
Sep 12, 2023
509: Add total field to get-tasks route r=irevoire a=hmacr # Pull Request ## Related issue Fixes #504 ## What does this PR do? - Adds `total` field to `get-tasks` route ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 516: Implement client for experimental-features API r=irevoire a=hmacr # Pull Request ## Related issue Needed for #498 & #501, since these issues involve updating the experimental-feature as a pre-requisite ## What does this PR do? - Introduces the experimental-features client in the SDK - Implements the `get` and `patch` endpoint. - Adds code-samples and tests. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: hmacr <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Sep 12, 2023
509: Add total field to get-tasks route r=curquiza a=hmacr # Pull Request ## Related issue Fixes #504 ## What does this PR do? - Adds `total` field to `get-tasks` route ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 516: Implement client for experimental-features API r=curquiza a=hmacr # Pull Request ## Related issue Needed for #498 & #501, since these issues involve updating the experimental-feature as a pre-requisite ## What does this PR do? - Introduces the experimental-features client in the SDK - Implements the `get` and `patch` endpoint. - Adds code-samples and tests. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: hmacr <[email protected]> Co-authored-by: Clémentine U. - curqui <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
|
Build succeeded: |
meili-bors bot
added a commit
that referenced
this pull request
Sep 12, 2023
519: Update version for v0.24.2 r=curquiza a=curquiza ## 🚀 Enhancements * Re-export public structures for better import path (#493) `@adriantombu` * Added function for sending NDJSON documents (#494) `@carlosb1` * Add missing startedAt field in EnqueuedTask (#485) `@sebastiantoh` * #499 (attributesToSearchOn) (#510) `@brendon-shf` * Add total field to get-tasks route (#509) `@hmacr` * Implement client for experimental-features API (#516) `@hmacr` Co-authored-by: curquiza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #504
What does this PR do?
totalfield toget-tasksroutePR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!