Make hitsCount always the number of hits (and not totalHits value)
#701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Hello
This is more a maintenance change here, nothing that impacts the product because totalHits is already supposed to always be the count of hits
Did you ask for this change because you noticed totalHits was different from the number of hits @johnnynotsolucky?
|
Hi @curquiza, I noticed that when |
curquiza
reviewed
Dec 9, 2024
curquiza
approved these changes
Dec 9, 2024
curquiza
changed the title
hitsCount always the number of hits (and not totalHits value)
meili-bors bot
added a commit
that referenced
this pull request
Dec 23, 2024
692: Changes related to the next Meilisearch release (v1.12.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#307 This PR: - gathers the changes related to the next Meilisearch release (v1.12.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.12.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ 705: Update version for the next release (v1.12.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-php to a new version: "v1.12.0" CHANGELOGS 👇 This version introduces features released on Meilisearch v1.12.0 🎉 Check out the [Meilisearch v1.12.0 changelog](https://github.com/meilisearch/meilisearch/releases/tag/v1.12.0) for more information. ## 🚀 Enhancements - **Addition:** #699 Introducing new methods to get one or several batches, respectively `getBatch()` and `getBatches()`. A batch is a set of tasks processed together. - **Addition:** #698 The `TaskQuery` class now has a `setReverse()` method to retrieve tasks in reverse chronological order. ```php client->getTasks((new TasksQuery())->setReverse(true)); ``` - **Addition:** #702 Index settings now allow disabling **prefix search** and **facet search**. They're both enabled by default. The SDK now comes with dedicated methods to configure these settings. ```php // disable prefix search $index->updatePrefixSearch('disabled'); // reset prefix search settings $index->resetPrefixSearch(); // disable facet search $index->updateFacetSearch(false); // reset facet search settings $index->resetFacetSearch(); ``` ## 🐛 Bug Fixes - fix: pull the latest in the CI instead of forcing the v1.11 (#691) `@/mdubus` - Make `hitsCount` always the number of `hits` (and not `totalHits` value) (#701) `@/johnnynotsolucky` ## ⚙️ Maintenance/misc - Update CI to run with PHP 8.4 (#696) `@/norkunas` - Fixed SearchNestedFieldsTest test (#704) `@/aivchen` - PHPStan 2 + fixed uninitialized properties in SearchResult (#706) `@/aivchen` Thanks again to `@/aivchen,` `@/johnnynotsolucky,` `@/mdubus,` `@/norkunas,` Andrei Ivchenkov, and `@/Strift!` 🎉 Co-authored-by: meili-bot <[email protected]> Co-authored-by: Clémentine <[email protected]> Co-authored-by: Strift <[email protected]> Co-authored-by: Laurent Cazanove <[email protected]>
meili-bors bot
added a commit
that referenced
this pull request
Dec 23, 2024
705: Update version for the next release (v1.12.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-php to a new version: "v1.12.0" CHANGELOGS 👇 This version introduces features released on Meilisearch v1.12.0 🎉 Check out the [Meilisearch v1.12.0 changelog](https://github.com/meilisearch/meilisearch/releases/tag/v1.12.0) for more information. ## 🚀 Enhancements - **Addition:** #699 Introducing new methods to get one or several batches, respectively `getBatch()` and `getBatches()`. A batch is a set of tasks processed together. - **Addition:** #698 The `TaskQuery` class now has a `setReverse()` method to retrieve tasks in reverse chronological order. ```php client->getTasks((new TasksQuery())->setReverse(true)); ``` - **Addition:** #702 Index settings now allow disabling **prefix search** and **facet search**. They're both enabled by default. The SDK now comes with dedicated methods to configure these settings. ```php // disable prefix search $index->updatePrefixSearch('disabled'); // reset prefix search settings $index->resetPrefixSearch(); // disable facet search $index->updateFacetSearch(false); // reset facet search settings $index->resetFacetSearch(); ``` ## 🐛 Bug Fixes - fix: pull the latest in the CI instead of forcing the v1.11 (#691) `@/mdubus` - Make `hitsCount` always the number of `hits` (and not `totalHits` value) (#701) `@/johnnynotsolucky` ## ⚙️ Maintenance/misc - Update CI to run with PHP 8.4 (#696) `@/norkunas` - Fixed SearchNestedFieldsTest test (#704) `@/aivchen` - PHPStan 2 + fixed uninitialized properties in SearchResult (#706) `@/aivchen` Thanks again to `@/aivchen,` `@/johnnynotsolucky,` `@/mdubus,` `@/norkunas,` Andrei Ivchenkov, and `@/Strift!` 🎉 Co-authored-by: meili-bot <[email protected]> Co-authored-by: Clémentine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #700
What does this PR do?
SearchResults::hitsCountis consistent regardless of whetherestimatedTotalHitsis set.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!